Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for IA-5062: add get_parent action to enum #4787

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

rtitle
Copy link
Collaborator

@rtitle rtitle commented Sep 20, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-5062

Summary of changes

In broadinstitute/sam#1543 we added the get_parent action to notebook-cluster and persistent-disk. Leo needs to enumerate all possible actions from Sam because it implements decoders for the resourceActionsV2 endpoint. This should not be a hard dependency anymore once we switch to the generated Sam client.

What

Why

Testing these changes

Reproed in a BEE by creating an app+disk then deleting it.
Verified it is successful after this PR.

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (b093874) to head (a0b1f39).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4787      +/-   ##
===========================================
- Coverage    74.79%   74.78%   -0.02%     
===========================================
  Files          165      165              
  Lines        14946    14948       +2     
  Branches      1178     1178              
===========================================
  Hits         11179    11179              
- Misses        3767     3769       +2     
Flag Coverage Δ
74.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b093874...a0b1f39. Read the comment docs.

Copy link
Collaborator

@cpate4 cpate4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rtitle rtitle enabled auto-merge (squash) September 20, 2024 15:37
@rtitle rtitle merged commit 629bb69 into develop Sep 20, 2024
22 of 23 checks passed
@rtitle rtitle deleted the rt-ia-5062-fix branch September 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants