Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-4295] [IA-4327] Add Sam client to Leonardo, populate workspace ID #4757

Merged
merged 18 commits into from
Aug 28, 2024

Update sam version to non-SNAP

f14f67a
Select commit
Loading
Failed to load commit list.
Merged

[IA-4295] [IA-4327] Add Sam client to Leonardo, populate workspace ID #4757

Update sam version to non-SNAP
f14f67a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 1s

74.22% (target 70.00%)

View this Pull Request on Codecov

74.22% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 82.48175% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.22%. Comparing base (54c8a19) to head (f14f67a).

Files Patch % Lines
...kbench/leonardo/dao/sam/SamApiClientProvider.scala 0.00% 9 Missing ⚠️
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% 4 Missing ⚠️
...te/dsde/workbench/leonardo/util/BucketHelper.scala 55.55% 4 Missing ⚠️
.../workbench/leonardo/dao/sam/SamServiceInterp.scala 96.00% 2 Missing ⚠️
...h/leonardo/http/service/RuntimeServiceInterp.scala 86.66% 2 Missing ⚠️
...rkbench/leonardo/auth/CloudAuthTokenProvider.scala 0.00% 1 Missing ⚠️
...rkbench/leonardo/http/GcpDependenciesBuilder.scala 85.71% 1 Missing ⚠️
...ench/leonardo/http/service/DiskServiceInterp.scala 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4757      +/-   ##
===========================================
+ Coverage    74.17%   74.22%   +0.05%     
===========================================
  Files          161      164       +3     
  Lines        14941    14981      +40     
  Branches      1226     1243      +17     
===========================================
+ Hits         11082    11120      +38     
- Misses        3859     3861       +2     
Files Coverage Δ
...sde/workbench/leonardo/http/diskRoutesModels.scala 0.00% <ø> (ø)
...ench/leonardo/auth/GcpCloudAuthTokenProvider.scala 0.00% <ø> (ø)
...dsde/workbench/leonardo/auth/SamAuthProvider.scala 58.77% <ø> (+0.44%) ⬆️
...titute/dsde/workbench/leonardo/config/Config.scala 97.76% <ø> (-0.03%) ⬇️
...itute/dsde/workbench/leonardo/dao/HttpSamDAO.scala 18.78% <ø> (ø)
...institute/dsde/workbench/leonardo/dao/SamDAO.scala 0.00% <ø> (ø)
...dsde/workbench/leonardo/dao/sam/SamException.scala 100.00% <100.00%> (ø)
...e/dsde/workbench/leonardo/dao/sam/SamService.scala 100.00% <100.00%> (ø)
...e/workbench/leonardo/db/DiskServiceDbQueries.scala 100.00% <ø> (ø)
...bench/leonardo/http/AzureDependenciesBuilder.scala 97.36% <100.00%> (ø)
... and 12 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c8a19...f14f67a. Read the comment docs.