Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dont Merge] GCSFuse as a sidecar #4529

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tarekmamdouh
Copy link
Contributor

I'm prototyping with the possibility of mounting a gcs bucket in jupyter image.
This is not intended to go to prod yet

Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (2d4dcfd) to head (84fc382).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4529   +/-   ##
========================================
  Coverage    73.99%   73.99%           
========================================
  Files          159      159           
  Lines        14784    14869   +85     
  Branches      1231     1213   -18     
========================================
+ Hits         10939    11002   +63     
- Misses        3845     3867   +22     

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4dcfd...84fc382. Read the comment docs.

@tarekmamdouh tarekmamdouh force-pushed the tarek/genomic-file-access-poc branch from 480436b to 8d50bcc Compare June 6, 2024 17:38
@tarekmamdouh tarekmamdouh changed the title [Dont Merge] Add device and sys admin capability to be able to mount a gcs bucket [Dont Merge] GCSFuse as a sidecar Jun 11, 2024

# Start gcsfuse as a sidecar
mkdir -p /mnt/disks/bucket
docker run -d --name gcsfuse-container --privileged -u root -e PIP_USER=false --env BUCKET_NAME=genomics-public-data --device /dev/fuse:/dev/fuse --security-opt apparmor=unconfined -v /mnt/disks/bucket:/mnt/gcs-bucket:shared tarekmahmed/gcsfuse-container:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you likely want to use the --restart always option so that the volume get's mounted properly after pausing / resuming your runtime, see

docker run -d --restart always --network host --name listener \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants