Metrics fix

DataBiosphere · Aug 20, 2024 · ffd65da · ffd65da
1 parent 02e949f
commit ffd65da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/auth/SamAuthProvider.scala b/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/auth/SamAuthProvider.scala
@@ -472,7 +472,7 @@ class SamAuthProvider[F[_]: OpenTelemetryMetrics](
       case Left(error) =>
         logger.warn(Map("traceId" -> traceId.asString))(
           s"Unable to populate workspace ID for google project $googleProject: $error"
-        ) >> metrics.incrementCounter(metricName, tags = Map("failed" -> "true"))
+        ) >> metrics.incrementCounter(metricName, tags = Map("succeeded" -> "false"))
     }
   } yield workspaceId.toOption
 

diff --git a/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/dao/HttpSamDAO.scala b/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/dao/HttpSamDAO.scala
@@ -575,7 +575,7 @@ class HttpSamDAO[F[_]](httpClient: Client[F],
   override def getResourceParent(authHeader: Authorization, resource: SamResourceId)(implicit
     ev: Ask[F, TraceId]
   ): F[Option[GetResourceParentResponse]] = for {
-    _ <- metrics.incrementCounter("sam/getParentResource")
+    _ <- metrics.incrementCounter("sam/getResourceParent")
     resp <- httpClient.expectOptionOr[GetResourceParentResponse](
       Request[F](
         method = Method.GET,