Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include order in src/reader.cpp which was broken by clang-format #7

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

sanathkeshav
Copy link
Collaborator

No description provided.

@sanathkeshav sanathkeshav force-pushed the debug_sk branch 2 times, most recently from edc8d80 to f9295f1 Compare August 23, 2024 16:26
@IshaanDesai
Copy link
Collaborator

So apparently it is a known fact that clang-format has the default behavior of sorting #include includes, which breaks C/C++ projects. Look at https://stackoverflow.com/questions/60334299/clang-format-disable-ordering-includes. Disabling SortIncludes seems to be an appropriate solution.

@IshaanDesai IshaanDesai changed the title Bug fix: Fixed include order in src/reader.cpp Bug fix: Fixed include order in src/reader.cpp which was broken by clang-format Aug 23, 2024
@IshaanDesai IshaanDesai changed the title Bug fix: Fixed include order in src/reader.cpp which was broken by clang-format Fix include order in src/reader.cpp which was broken by clang-format Aug 23, 2024
@IshaanDesai IshaanDesai merged commit 6bea71e into develop Aug 23, 2024
4 checks passed
@IshaanDesai IshaanDesai deleted the debug_sk branch August 24, 2024 18:41
This was referenced Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants