The LS1 PR: Introduce system for checking compiler flags: avx2 & fma #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
claudiushaag
commented
Nov 1, 2024
claudiushaag
commented
- i7-2600 was otherwise not able to built
- super backward change
- does not apply/test on macos
+ i7-2600 was otherwise not able to built + super backward change + does not apply/test on macos
claudiushaag
added
bug
claudiushaag
changed the title
siggmo
requested changes
Nov 4, 2024
siggmo
approved these changes
Dec 2, 2024
CMakeLists.txt
Outdated
| target_compile_options(FANS_FANS PUBLIC -mavx2 -mfma) | ||
| elseif (CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| # Linux: Check for AVX2 support using lscpu | ||
| execute_process(COMMAND lscpu OUTPUT_VARIABLE LSCU_OUTPUT ERROR_QUIET) |
There was a problem hiding this comment.
typo: missing P in LSCU_OUTPUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.