-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CTest test cases from existing tests (run_tests.sh) #20
Conversation
…iner' option The container option doesn't support QEMU emulation and thus selecting a architecture different from the runners/host's one crashed the container with a 'exec format error'. Unfortunately this breaks running the workflows locally using nektos/act. I still have to figure out why exactly.
…es instead of double quotes to prevent host side shell expansion
Apparently MPI isn't able to obtain the required "slots" when running in the GitHub Action. Locally on my machine it worked... I have to investigate that further. Here's the error:
Do you have any ideas what could be going wrong? |
"For example, GitHub Actions only have 2 cores available for Windows and Linux, yet 3 for macOS." mentioned in: vercel/turborepo#761 can't request 4 cores for building or for testing that's all. |
Ahh okay makes sense! I used the CMake function |
… fans-ci image as well
…se of container: parameter
…number of physical cores, which is the relevant number for MPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe
Co-authored-by: Sanath Keshav <[email protected]>
This PR should not be merged before PR #19!
Adressing #9
CMake comes with a testing tool called CTest. This PR adds the existing test cases from
test/run_tests.sh
as CTest test cases. Instead of maintaining a dedicated test shell script, CTest allows to define the tests in the existing CMake build system and offers useful functions for testing like measuring execution time, collecting outputs, checking for assertions etc.You can run the tests by calling
ctest
in the build directory. To see the full output, add the-VV
flag.Features
<build-dir>/test/
, such that running the tests only creates/alters files in the build treeOpen points