Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRIORITY MERGE] FIXES WORKFLOWS COMPILE ISSUES, updates bug report #1263

Merged
merged 2 commits into from
Jan 20, 2025
Merged

[PRIORITY MERGE] FIXES WORKFLOWS COMPILE ISSUES, updates bug report #1263

merged 2 commits into from
Jan 20, 2025

Conversation

ThePainkiller
Copy link
Contributor

@ThePainkiller ThePainkiller commented Jan 13, 2025 •
edited
Loading

MERGE ME NOW AND GET A FREE MASTERWORK iSCOM

  • Adds the current maps in rotation, obsoletes Dakkatown as unused
  • Better grammar
  • Actually fucking installs NET Framework as it's a dependancy for our compile workflow to run jesus christ

Why It's Good For The Game

  • This is mostly a test PR to check if github workflows compile is still broken somehow due to requirint .NET Framework 9.0. Tested locally, compiles and runs, no issues.
  • On a more serious note, for people to be able to properly report which map anything happened on.
  • Solves our fucking issue with BYOND compile not working due to a lack of NET Framework installation

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@ThePainkiller
Update bug_report.yml
34c4790 
- Adds the current maps in rotation, obsoletes Dakkatown as unused
-  Better grammar
- This is mostly a test PR to check if github workflows compile is still broken somehow due to requirint .NET Framework 9.0
@ThePainkiller ThePainkiller added the Bugfix This PR splats some undesired bugs. Neat! label Jan 13, 2025
@ThePainkiller
Update ci_suite.yml
a7a0da6 
For the love of god I hate NET Framework
@ThePainkiller ThePainkiller changed the title Updates bug_report.yml [PRIORITY MERGE] FIXES WORKFLOWS COMPILE ISSUES, updates bug report Jan 20, 2025
@Catalaria
Copy link

IS STONEKEEP SAVED???? SOMEONE SPEEDMERGET HIS!!!!!!!!!!!

@ThePainkiller ThePainkiller added the Ready to merge This PR is approved and ready to merge label Jan 20, 2025
@ThePainkiller
Copy link
Contributor Author

SUCK MY THROBBING, VEINY COCK BYOND COMPILE, WE ARE SO BACK

@Catalaria
Copy link

LET'S FUCKING GOOOOOOOOOOOOOOOOOOOO

hermaplusplus
hermaplusplus approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hermaplusplus hermaplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You owe me a 'FREE MASTERWORK iSCOM', whatever that is.

@hermaplusplus hermaplusplus merged commit a1787e1 into Darkrp-community:main Jan 20, 2025
7 checks passed
@ThePainkiller ThePainkiller deleted the updatebugreport branch January 20, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermaplusplus hermaplusplus hermaplusplus approved these changes

Assignees
No one assigned
Labels
Bugfix This PR splats some undesired bugs. Neat! Ready to merge This PR is approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThePainkiller @Catalaria @hermaplusplus