Simplify decal system. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `freedecal` field, and as such, fixes some invariant violations found in issue #216 that appear to lead to engine crashes. Performance should remain unchanged, as the decal expiry process performed full decal copies from end spots to unoccupied spots as part of its "shuffling" loop anyway. Fixes issue #216.
|
It works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
freedecalfield, and as such, fixes some invariant violations found in issue #216 that appear to lead to engine crashes.Performance should remain unchanged, as the decal expiry process performed full decal copies from end spots to unoccupied spots as part of its "shuffling" loop anyway. New decals are now always added to the end, and when a decal expires, it's now always replaced by the current last decal in the list. If only one decal were to expire per frame, this matches the previous behavior, so I am not expecting any visible differences due to decal Z index in regular gameplay from this either.
Fixes issue #216.