Print centerprint messages to the console #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e previous centerprint message
|
You seem to have included an unused global Do you have plans to call Con_CenterPrint() from other places? If not then IMO this should be inlined in SCR_CenterPrint(). |
Cheers. That was going to hold the previous message before I found
I don't think there are other places from where I would call it. You would prefer for the contents of |
|
Yes please, we can always split it out later if we find a reason to. |
|
All done. |
… center-aligning centerprint messages in the console.
…about too-long messages.
Signed-off-by: bones_was_here <[email protected]>
Signed-off-by: bones_was_here <[email protected]>
Parm names and the printf attribute make IDEs and other tools more useful. Signed-off-by: bones_was_here <[email protected]>
Fixes printing an empty message when stepping out of the trigger on alk1.2 start.bsp, and repeated prints of the same message when those are triggered repeatedly. Signed-off-by: bones_was_here <[email protected]>
bones-was-here
added a commit
that referenced
this pull request
May 31, 2024
This code was OK, but if someone were to change the buffer size(s) such that line[] were smaller than msg[], or were to call Con_CenterPrintf() with a maxLineLength > 40, then a buffer overflow would have become possible. This patch prevents it. See #159 Signed-off-by: bones_was_here <[email protected]>
bones-was-here
added a commit
that referenced
this pull request
Aug 1, 2024
Fixes a bug introduced by me in #159 where a `svc_finale` message with the empty string could cause a previously displayed engine centreprint to appear again. Signed-off-by: bones_was_here <[email protected]>
nyov
pushed a commit
to xonotic/darkplaces
that referenced
this pull request
Aug 5, 2024
Fixes a bug introduced by me in DarkPlacesEngine/DarkPlaces#159 where a `svc_finale` message with the empty string could cause a previously displayed engine centreprint to appear again. Signed-off-by: bones_was_here <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function
Con_CenterPrintwhich can be used to print messages to the console, without showing onscreen, and with a "horizontal rule" above and below. UseCon_CenterPrintto log centerprint messages to the console.Fixes #98