Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in specs #17

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Changes in specs #17

merged 5 commits into from
Aug 19, 2024

Conversation

DarikshaAnsari
Copy link
Owner

@DarikshaAnsari DarikshaAnsari commented Aug 9, 2024

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for in-toto-docs ready!

Name Link
🔨 Latest commit 5e306f1
🔍 Latest deploy log https://app.netlify.com/sites/in-toto-docs/deploys/66bb7585bec6540008614f6d
😎 Deploy Preview https://deploy-preview-17--in-toto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chalin
Copy link
Collaborator

chalin commented Aug 9, 2024

@DarikshaAnsari - rebase this PR (from main) and force push the result. Do the same thing for your other open PR.

Signed-off-by: Dariksha <[email protected]>
@DarikshaAnsari
Copy link
Owner Author

@chalin Done with rebase.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there! See inline comments for required changes.

content/en/docs/spec-table.md Outdated Show resolved Hide resolved
layouts/shortcodes/specs.html Outdated Show resolved Hide resolved
layouts/shortcodes/specs.html Outdated Show resolved Hide resolved
content/en/docs/spec-table.md Outdated Show resolved Hide resolved
@DarikshaAnsari DarikshaAnsari requested a review from chalin August 10, 2024 05:59
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.

LGTM once you address the two issues described in the inline comments

layouts/shortcodes/spec-table.md Outdated Show resolved Hide resolved
data/specs.yaml Show resolved Hide resolved
@DarikshaAnsari DarikshaAnsari requested a review from chalin August 11, 2024 12:27
@DarikshaAnsari
Copy link
Owner Author

cc:- @lukpueh

@lukpueh
Copy link
Collaborator

lukpueh commented Aug 13, 2024

Just saw that the spec link on the Docs overview page ("Dive into the in-toto Technical Specification for ...") 404s now.

Please make sure to update any remaining "spec-table" links.

@DarikshaAnsari DarikshaAnsari requested a review from lukpueh August 13, 2024 11:47
@lukpueh
Copy link
Collaborator

lukpueh commented Aug 13, 2024

Still doesn't work. You need to change "docs/spec-table" to "docs/specs". Also on the landing page.

Copy link
Collaborator

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about spec-table above.

@DarikshaAnsari DarikshaAnsari requested a review from lukpueh August 13, 2024 15:02
@DarikshaAnsari DarikshaAnsari merged commit 028da46 into main Aug 19, 2024
5 checks passed
@chalin chalin deleted the patch-specs branch August 22, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifications page: make the table look like the original site Fix spec related files
3 participants