-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in specs #17
Changes in specs #17
Conversation
DarikshaAnsari
commented
Aug 9, 2024
•
edited by chalin
Loading
edited by chalin
- Fixes Fix spec related files #13
- Fixes Specifications page: make the table look like the original site #15
✅ Deploy Preview for in-toto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@DarikshaAnsari - rebase this PR (from |
Signed-off-by: Dariksha <[email protected]>
0405cd6
to
bb8fe99
Compare
@chalin Done with rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there! See inline comments for required changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better.
LGTM once you address the two issues described in the inline comments
cc:- @lukpueh |
Just saw that the spec link on the Docs overview page ("Dive into the in-toto Technical Specification for ...") 404s now. Please make sure to update any remaining "spec-table" links. |
Still doesn't work. You need to change "docs/spec-table" to "docs/specs". Also on the landing page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about spec-table above.