Remove deprecated code and revert test id

DaoDaoNoCode · Oct 30, 2024 · fdd9e33 · fdd9e33
1 parent b39517f
commit fdd9e33
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/pages/workbench.ts b/frontend/src/__tests__/cypress/cypress/pages/workbench.ts
@@ -182,7 +182,7 @@ class NotebookRow extends TableRow {
   }
 
   findNotebookStatusPopover(name: string) {
-    return cy.findByTestId('workbench-status-popover').contains(name);
+    return cy.findByTestId('notebook-status-popover').contains(name);
   }
 }
 

diff --git a/frontend/src/pages/projects/notebook/NotebookStateStatus.tsx b/frontend/src/pages/projects/notebook/NotebookStateStatus.tsx
@@ -74,7 +74,7 @@ const NotebookStateStatus: React.FC<NotebookStateStatusProps> = ({
     return (
       <>
         <Popover
-          data-testid="workbench-status-popover"
+          data-testid="notebook-status-popover"
           shouldClose={() => setPopoverVisible(false)}
           isVisible={isPopoverVisible}
           headerContent="Workbench status"

diff --git a/frontend/src/pages/projects/notebook/StartNotebookModal.tsx b/frontend/src/pages/projects/notebook/StartNotebookModal.tsx
@@ -46,17 +46,6 @@ const StartNotebookModal: React.FC<StartNotebookModalProps> = ({
 
   const spawnFailed = spawnStatus?.status === AlertVariant.danger;
 
-  React.useEffect(() => {
-    if (isRunning) {
-      setSpawnPercentile(100);
-      setSpawnStatus({
-        status: AlertVariant.success,
-        title: 'Success',
-        description: 'The notebook server is up and running.',
-      });
-    }
-  }, [isRunning]);
-
   React.useEffect(() => {
     if (isStarting && !isRunning) {
       if (!notebookStatus) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -182,7 +182,7 @@ class NotebookRow extends TableRow { @@
       }
       findNotebookStatusPopover(name: string) {
-        return cy.findByTestId('workbench-status-popover').contains(name);
+        return cy.findByTestId('notebook-status-popover').contains(name);
       }
     }
@@ Expand Down @@