Skip to content

Commit

Permalink
Microcopy updates for project list view
Browse files Browse the repository at this point in the history
  • Loading branch information
DaoDaoNoCode committed Oct 31, 2024
1 parent 21907eb commit f72b604
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
13 changes: 10 additions & 3 deletions frontend/src/pages/projects/notebook/StopNotebookConfirmModal.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';
import { Button, Checkbox, Flex, FlexItem, Modal, Stack, StackItem } from '@patternfly/react-core';
import { getDisplayNameFromK8sResource } from '~/concepts/k8s/utils';
import NotebookRouteLink from './NotebookRouteLink';
import useStopNotebookModalAvailability from './useStopNotebookModalAvailability';
import { NotebookState } from './types';
Expand Down Expand Up @@ -47,14 +48,20 @@ const StopNotebookConfirmModal: React.FC<StopNotebookConfirmProps> = ({
>
<Stack hasGutter>
<StackItem>
Are you sure you want to stop the workbench? Any changes without saving will be erased.
Any unsaved changes to the <strong>{getDisplayNameFromK8sResource(notebook)}</strong>{' '}
workbench will be lost.
</StackItem>
{isRunning && (
<StackItem>
<Flex>
<FlexItem spacer={{ default: 'spacerXs' }}>To save changes, access your</FlexItem>
<FlexItem spacer={{ default: 'spacerXs' }}>To save changes, </FlexItem>
<FlexItem spacer={{ default: 'spacerNone' }}>
<NotebookRouteLink label="workbench" notebook={notebook} isRunning isLarge />
<NotebookRouteLink
label="open the workbench"
notebook={notebook}
isRunning
isLarge
/>
</FlexItem>
<FlexItem spacer={{ default: 'spacerNone' }}>.</FlexItem>
</Flex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const LaunchJupyterButton: React.FC = () => {
return (
<Tooltip
position="left"
content="Launch a notebook server to create a standalone notebook outside of a project."
content="Launch a notebook server to create a standalone workbench outside of a project."
>
<Button
data-testid="launch-standalone-notebook-server"
Expand All @@ -26,7 +26,7 @@ const LaunchJupyterButton: React.FC = () => {
navigate('/notebookController');
}}
>
Launch standalone notebook server
Launch standalone workbench
</Button>
</Tooltip>
);
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/projects/screens/projects/tableData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ const WorkBenchDescription = (
<div>
<div>
<PlayIcon className="pf-v5-u-mr-xs" />
Indicates number of running or starting workbenches.
The total number of running or starting workbenches in the project.
</div>
<div>
<OffIcon className="pf-v5-u-mr-xs" />
Indicates number of stopped workbenches.
The total number of stopped workbenches in the project.
</div>
</div>
);
Expand All @@ -38,7 +38,7 @@ export const columns: SortableData<ProjectKind>[] = [
sortable: false,
width: 30,
info: {
popoverProps: { headerContent: 'Workbench counts', hasAutoWidth: true },
popoverProps: { hasAutoWidth: true },
popover: WorkBenchDescription,
},
},
Expand Down

0 comments on commit f72b604

Please sign in to comment.