feat : complete progress page #88
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@SamTheKorean 프로그레스 페이지까지 데모를 하기에는 너무 PR이 늦게 올라온 거 아닌가 싶어요 😓 너무 서두르다가 다른 부작용을 일으키기 보다는 우리가 비현실적인 목표를 설정했다는 것을 인정하고, 너무 무리하지 말고 오늘은 아쉽지만 되는데까지 데모를 하면 어떨까요? |
DaleSeo
reviewed
Nov 23, 2024
| @@ -0,0 +1,92 @@ | |||
| import { useEffect } from "react"; | |||
| import styles from "./Aside.module.css"; | |||
| import Seed from "../../assets/Seed.png"; | |||
There was a problem hiding this comment.
assets 디렉토리에 이미지 파일이 없는 것 같은데요?
There was a problem hiding this comment.
아 드래프트로 올려놓고 다른 pr 마지되면 rebase해서 가져와서 올리고 pr 오픈할 예정이었습니다..! 여기에 올리면 충돌을 해결해야할 것 같아서요.! 생각해보니 같은 파일이라 충돌은 안날 수 있겠네요..! 떠나서 다른 분들에게 혼란을 드리는 것 같으니 이제는 충돌이 예상되더라도 우선 올리고 해결하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트