Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

스토리북 접근성 애드온 설정 #86

Merged
merged 1 commit into from
Nov 23, 2024
Merged

스토리북 접근성 애드온 설정 #86

merged 1 commit into from
Nov 23, 2024

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Nov 23, 2024

제가 코드 리뷰를 하는데 웹 접근성에 문제의 소지가 있는 구현이 이곳 저곳에 눈에 띄더라고요 😵 UI 구현을 하시면서 접근성 문제를 스토리북을 통해서 스스로 인지하시고 가이드를 받으실 수 있도록 관련 애드온을 추가하였습니다.

Shot 2024-11-23 at 11 56 45

Shot 2024-11-23 at 11 57 40

Shot 2024-11-23 at 11 58 26

체크리스트

@DaleSeo DaleSeo requested a review from a team as a code owner November 23, 2024 17:00
@DaleSeo DaleSeo mentioned this pull request Nov 23, 2024
2 tasks
Copy link
Member

@sounmind sounmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋은데요? 이런 기능도 있었다니, 스토리북이 점점 좋아집니다...

Copy link
Contributor

@Sunjae95 Sunjae95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 접근성테스트는 어떻게 해야할지 막막했는데 애드온으로 결과를 확인할 수 있군요..?!
이미 개발된것은 해당 테스트를 통해 티켓작성해서 todo로 남겨놓기 좋을거같고, 작업예정은 애드온으로 확인해서 더욱 단단한 컴포넌트를 구현할 수 있을거같아 좋은거 같습니다!

@DaleSeo DaleSeo merged commit 5336c2e into main Nov 23, 2024
2 checks passed
@DaleSeo DaleSeo deleted the 85-sb-a11y branch November 23, 2024 18:46
@DaleSeo DaleSeo mentioned this pull request Nov 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

스토리북 접근성 애드온 설정
3 participants