Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add draft for data module #28

Merged
merged 128 commits into from
Nov 7, 2024
Merged

Feat: add draft for data module #28

merged 128 commits into from
Nov 7, 2024

Conversation

HC-kang
Copy link
Contributor

@HC-kang HC-kang commented Oct 22, 2024

데이터 조회 모듈의 초안입니다.

이전에 테스트용으로 사용한 코드를 그대로 옮겨두어 추가적인 정리가 필요합니다.
그러나 개략적인 흐름은 동일할것으로 생각되어, 우선 초안 수준으로 공유드립니다!

  • 테스트 방법

    • 깃허브 read:org 토큰 기입(/src/api/getMembersByCohort.ts)
    • bun ./src/api/index.ts

  • TODO

    • getTeams API 활용
    • display 등 미사용 로직 제거
    • SubmissionOfMember 등 타입 구체화
    • 기타 로직, 코드 개선 등등

@HC-kang HC-kang linked an issue Oct 22, 2024 that may be closed by this pull request
데이터 조회 모듈 개발 #25
Closed
DaleSeo and others added 19 commits October 22, 2024 20:17
@DaleSeo
fix: type erros with jest-dom
1cf4c52
@DaleSeo
ci: add integration workflow
56e239f
@DaleSeo
chore: do not clutter test output with errors
3f79d97
@Sunjae95
fix: global css for storybook
02b602b
@Sunjae95
Merge pull request #32 from DaleStudy/30-storybook-global-css
31bbf09 
fix: global css for storybook
@DaleSeo
Merge pull request #29 from DaleStudy/ci-integration
feaaa8f 
통합 워크플로우
@SamTheKorean
feat : implement progress component
38021c1
@SamTheKorean
feat : implement progress story
d8f96be
@SamTheKorean
feat : implement progress test
9f163b7
@SamTheKorean
feat : implement index page
6fbfe7a
@SamTheKorean
fix : refactor test cases and remove unused dependancy
e6590c1
@SamTheKorean
Merge pull request #31 from DaleStudy/sam/create-progress-page
d4639a7 
Feat : Implement progress page component
@SamTheKorean
fix : clean up css not required
2378ee2
@SamTheKorean
feat : implement leaderboard component
0c95ee6
@SamTheKorean
feat : implement story for leaderboard
7069566
@SamTheKorean
feat : implement unit test for leaderboard
ed91ab0
@SamTheKorean
feat : implement index page
f13112a
@SamTheKorean
fix : refactor test and remove unused imports
8b0ba70
@DaleSeo
ci: add deployment workflow
ee0c9cc
@DaleSeo
Copy link
Contributor

DaleSeo commented Oct 25, 2024

이전에 테스트용으로 사용한 코드를 그대로 옮겨두어 추가적인 정리가 필요합니다.
그러나 개략적인 흐름은 동일할것으로 생각되어, 우선 초안 수준으로 공유드립니다!

@HC-kang 님, 초안 공유해주셔서 감사합니다. 모임 때 잘 설명해주셔서 잘 이해가 됩니다. 추후에 최종 구현을 하실 때는 테스트 코드도 작성해주시면 더 리뷰가 편할 것 같습니다.

DaleSeo
DaleSeo reviewed Oct 25, 2024
View reviewed changes
src/api/types.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입을 이렇게 하나의 파일로 중앙화 시키셨네요. 코드를 읽기 좀 더 수월하도록 함수 근처에 타입을 두는 것도 고려해보셨으면 좋겠습니다.

@DaleSeo
Copy link
Contributor

DaleSeo commented Oct 26, 2024 •
edited
Loading

Just FYI, 타입 오류가 발생하고 있네요.

Shot 2024-10-26 at 10 07 51@2x

https://github.com/DaleStudy/leaderboard/actions/runs/11530488155/job/32100129671?pr=28

@HC-kang
feat: add store service local storage cache
57e9ff3
@HC-kang
feat: add hard refresh to get data
2ae8ade
@HC-kang
chore: cleanup directory structure
77ac38d
@HC-kang
typo
e39bbde
@HC-kang
rename: modify file name and remove cache
2048e99
@HC-kang
remove: renamed file
fadf497
@HC-kang
feat: add renamed file
f4806d6
@HC-kang
rename: rename file
049de21
@HC-kang
rename: rename file
3319125
@HC-kang
rename: github directory
2498290
@HC-kang
rename: gitHub directory
dd44373
@HC-kang
remove: caching feature in store service
b298f45
@HC-kang
style: arrow to function for exported functions
1c4aae0
@HC-kang
test: fix mock type safety
6f70aa0
@HC-kang
remove: unused features
7bbd017
@HC-kang
test: update test for feature change
ff22c69
@HC-kang
refactor: apply review comments
618236a
@HC-kang
test: remove invalid cohort test
b7ef969
@HC-kang
typo: 오탈자 수정
dafdbfd
@HC-kang
Merge branch 'feature/25-add-data-retrieve-module' of https://github.…
31e28ac 
…com/DaleStudy/leaderboard into feature/25-add-data-retrieve-module
@HC-kang HC-kang merged commit 1a6c86b into main Nov 7, 2024
1 check passed
@HC-kang HC-kang deleted the feature/25-add-data-retrieve-module branch November 7, 2024 00:17
@Sunjae95
Copy link
Contributor

Sunjae95 commented Nov 7, 2024 •
edited
Loading

수고많으셨습니다!🙌
grade type 사용하다가 중복되는 코드 발견해서 문의드려요.
/api/type.ts 와 /api/types.ts 중 무엇을 사용하면 될까요?

@sounmind
Copy link
Member

sounmind commented Nov 7, 2024 •
edited
Loading

끝까지 챙겨주신 희찬님, 리뷰해주신 달레님. 모두 고생하셨습니다!
이후에 생기는 이슈나 의문점들 디스코드나 깃허브 활용해서 계속 개선해나갔으면 좋겠습니다.

@sounmind
Copy link
Member

sounmind commented Nov 7, 2024

수고많으셨습니다!🙌 grade type 사용하다가 중복되는 코드 발견해서 문의드려요. /api/type.ts 와 /api/types.ts 중 무엇을 사용하면 될까요?

저도 현재 같은 문제를 겪고 있었어요! 이슈로 만들어서 팔로업하면 좋겠네요.

This was referenced Nov 7, 2024
Closed
Merged
@DaleSeo DaleSeo mentioned this pull request Nov 8, 2024
Closed
@DaleSeo DaleSeo mentioned this pull request Nov 22, 2024
Merged
1 task
@DaleSeo DaleSeo mentioned this pull request Nov 29, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sounmind sounmind sounmind left review comments

@DaleSeo DaleSeo DaleSeo approved these changes

Assignees

@HC-kang HC-kang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

데이터 조회 모듈 개발
5 participants
@HC-kang @DaleSeo @Sunjae95 @sounmind @SamTheKorean