Update for pcp-dstat and Bootstrap 5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest bootstrap and jquery Remove nv.d3.js which is shipped as a minimised file
Remove a bunch of styling that is no longer necessary
This converts the page to use bootstrap 5
This reduces the space around the "focus" slider
gCSVs is the input array made by the static generation script. Fix up the array walk.
This is the bootstrap 5 way to do a list group; add each graph as a list-group-item.
It seems like sometimes (perhaps with pcp dstat output that didn't happen before) we can get a blank line at the end. Make sure all lines have a length before processing.
Headers slightly changed in pcp-dstat output, and the chart we need to get is called "total usage:idl". Look for this field, or fall back to the old one to support both output formats.
Use the new library names, and make sure there's a newline before closing the script tag, as some minimised libraries end with a comment to the .map file and no trailing newline, meaning we comment-out the tag.
Update sample html and screenshot
When we don't have files, refresh from the embedded CSV's
openstack-mirroring
pushed a commit
to openstack/project-config
that referenced
this pull request
Nov 22, 2021
This is an import of the upstream project which has not had a commit in 4 years. I made a pull request that has gone uncommented for several weeks [1]. Ergo, I think we can consider this project inactive upstream. With the pull request updates, it is in somewhat of a steady state. It uses a outdated version of d3.js but otherwise is maintainable. So far, we've not found anything else that gives a simple stand-alone overview of background dstat runs and can be stuffed into a Zuul artifact quite as easily. Import the project and we can incorporate our changes from there. [1] Dabz/dstat_graph#6 Change-Id: I9ee4ab5e78571c174601a408d9d14209d9c0b625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We use this useful page in our CI jobs. Despite the death of dstat (replaced by pcp dstat wrappers now), nvd3 seeming to be dead and this being on a very old version of D3 it still gets the job done.
The main problem was the focus panel not working with pcp-dstat output
This updates the page to use Bootstrap 5 to fix display issues with the menu. It also updates the non-graphing dependencies and fixes a few small issues.