Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump next + yarn + storybook #910

Merged
merged 13 commits into from
Nov 14, 2023
Merged

bump next + yarn + storybook #910

merged 13 commits into from
Nov 14, 2023

Conversation

Fbasham
Copy link
Member

@Fbasham Fbasham commented Oct 31, 2023 •
edited by will0684
Loading

Bump next to version 14, yarn to v4, and storybook to v7.5.3

Also ran npm upgrade @storybook/nextjs (see here, storybook is really a major root cause in a lot of our dependency issues).

Had to also update /storybook.preview.js per this

@github-actions GitHub Actions
Copy link

Coverage Report Link for Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/910/merge/coverage/lcov-report

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@Fbasham Fbasham marked this pull request as draft October 31, 2023 14:15
@github-actions GitHub Actions
Copy link

Storybooks Link For Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/910/merge

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@Fbasham Fbasham marked this pull request as ready for review October 31, 2023 14:36
@andr0272
Copy link
Contributor

andr0272 commented Nov 1, 2023

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@andr0272
Copy link
Contributor

andr0272 commented Nov 1, 2023

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@andr0272
Copy link
Contributor

andr0272 commented Nov 1, 2023

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@andr0272
Copy link
Contributor

andr0272 commented Nov 8, 2023

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@Fbasham Fbasham requested a review from a team November 8, 2023 13:07
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@will0684 will0684 changed the title bump next bump next + yarn + storybook Nov 10, 2023
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

@will0684 will0684 merged commit 29d40ef into main Nov 14, 2023
5 checks passed
@will0684 will0684 deleted the bump-next branch November 14, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will0684 will0684 will0684 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fbasham @andr0272 @will0684