update ZAP #887
Merged
update ZAP #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybooks Link For Branch |
|
Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1.azurewebsites.net |
|
Coverage Report Link for Branch |
update zap test
|
Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify ZAP test to be more in line with other DTS products. Before this PR, ZAP was being run against every pull request against the (now) outdated alpha site URL. Because the URL was outdated, the test didn't actually do anything and would silently fail (this can be seen if you check the logs on previous PRs). This change aligns SC Labs with other DTS products by running the ZAP test against the main branch after a merge.