Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove design system #871

Merged
merged 1 commit into from
Sep 19, 2023
Merged

remove design system #871

merged 1 commit into from
Sep 19, 2023

Conversation

Fbasham
Copy link
Member

@Fbasham Fbasham commented Sep 13, 2023 •
edited
Loading

Remove design system components

Changes

  • remove SC Design System dependency
  • add DS components we were depending on
  • add necessary styles
  • update locales

Note: Design System components have been added to a design-system folder in case we need to do some future debugging.

@github-actions
Copy link

Storybooks Link For Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/871/merge

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

@github-actions
Copy link

Coverage Report Link for Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/871/merge/coverage/lcov-report

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

1 similar comment
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

@Fbasham Fbasham requested a review from a team September 14, 2023 11:27
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

will0684
will0684 reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@will0684 will0684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here! Only issue I see is the text colour of the button on the CTA

Screenshot 2023-09-15 at 8 46 53 AM

@Fbasham
Copy link
Member Author

Fbasham commented Sep 18, 2023 •
edited
Loading

Nice job here! Only issue I see is the text colour of the button on the CTA
Screenshot 2023-09-15 at 8 46 53 AM

Interestingly, it doesn't have the same effect in Firefox:

image

Need to see what class is overriding the other.

@Fbasham
initial commit
a50496c 
second commit
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

@Fbasham Fbasham requested a review from will0684 September 19, 2023 14:44
will0684
will0684 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@will0684 will0684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@will0684 will0684 merged commit 9ccb692 into main Sep 19, 2023
6 checks passed
@will0684 will0684 deleted the rm-ds branch September 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will0684 will0684 will0684 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fbasham @andr0272 @will0684