[fix] modify backgroundImage paths in tailwind.config.js #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybooks Link For Branch |
|
Coverage Report Link for Branch |
Fbasham
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splash image is not displaying
This PR fixes an issue that arose where the splash image was not being properly webpack bundled as part of the CSS. The problem was including "../public/" in the image paths inside the
tailwind.config.js. Nextjs assumes "/public/" as the root path of assets when bundling so it was looking in the wrong place.This wasn't an issue before, strangely enough, but this is how things should have worked previously. Likely due to a recent dependency change.
Test Instructions