[fix] Modify dcterms.title and dcterms.creator values #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice Canada to ESDC
|
Storybooks Link For Branch |
|
Coverage Report Link for Branch |
Fbasham
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
up to you if you want to move these into the common locale files since t is already being used. It's a small nitpick, but either way I'm fine with this
Actually, since I was planning on refactoring metadata alongside the gql rendering engine, you don't even need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify dcterms.title and dcterms.creator values
This addresses issues raised by the AA Data team related to null value page titles in AA and to an incorrect value of "Service Canada" for dcterms.creator. Task card in ADO includes the change request email.