Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] add recursive gql-node-renderer #847

Merged
merged 4 commits into from
Sep 20, 2023
Merged

[frontend] add recursive gql-node-renderer #847

merged 4 commits into from
Sep 20, 2023

Conversation

Fbasham
Copy link
Member

@Fbasham Fbasham commented Aug 23, 2023

Implement support for Benefits Navigator update/blog pages

Description

This code is intended to remove the need for hard-coding the HTTP response data returned from our GraphQL data fetching. More specifically, this code introduces a recursive react component that accepts the JSON data as props, and reconstructs the DOM from that data.

@github-actions
Copy link

Storybooks Link For Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/847/merge

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

@github-actions
Copy link

Coverage Report Link for Branch
https://dts-stn.github.io/Service-Canada-Labs/refs/pull/847/merge/coverage/lcov-report

@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

@Fbasham Fbasham force-pushed the fb-recur branch 2 times, most recently from 7e8ff05 to f579070 Compare August 24, 2023 18:35
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

@Fbasham Fbasham force-pushed the fb-recur branch 2 times, most recently from 6a7179b to 847195f Compare August 24, 2023 18:56
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

@Fbasham Fbasham requested a review from a team August 29, 2023 13:01
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

@Fbasham Fbasham removed the request for review from a team September 7, 2023 18:27
@Fbasham Fbasham force-pushed the fb-recur branch 2 times, most recently from 0d1ee44 to c887d1d Compare September 7, 2023 18:44
@Fbasham
resolve merge conflicts
d6753bd 
change fallback to blocking
@Fbasham Fbasham requested a review from a team September 11, 2023 11:56
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

will0684
will0684 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@will0684 will0684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thank you!

@will0684 will0684 merged commit de2b666 into main Sep 20, 2023
4 of 5 checks passed
@will0684 will0684 deleted the fb-recur branch September 20, 2023 18:27
@andr0272
Copy link
Contributor

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-0.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will0684 will0684 will0684 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fbasham @andr0272 @will0684