Design Update October 2024 #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unit testing for ArticleCTA component * Unit testing for BasicTextWithImage component * Unit testing for Button component * fixed typos in ImageWithCollapse.stories.js * Unit testing for ImageWithCollapse component * Unit testing for QuoteVerticalLineContent component * Unit testing for ImageVerticalLineContent component * Unit testing for TextContent component * Unit testing for TextWithImage component * updated alt arg value to match unit test query * fix dcterms metadata to better support AA (#1019) * Font Optimization (#1020) * setup google fonts to be served locally * implement fonts using next/font * apply Lato and Notosans variables directly to Modal * remove duplicate main landmark * fix duplicate main landmarks in error pages * added on click test-case for ImageWithCollapse.test * small update to ImageWithCollapse.test * stashing WIP changes for ImageWithCollapse.test.js * updated title path for fragment components * Created storybook entry for FragmentRender component * created unit test for FragmentRender component * add missing ISR_ENABLED ARG to Dockerfile (#1030) * add nullish coalescing operator to error page AA check (#1024) * upgrade nextjs version to fix issue with sharp and output:standalone (#1025) * [Snyk] Upgrade: react, react-dom (#1026) * fix: upgrade multiple dependencies with Snyk Snyk has created this PR to upgrade: - react from 18.2.0 to 18.3.1. See this package in yarn: - react-dom from 18.2.0 to 18.3.1. See this package in yarn: See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade i18next from 23.10.1 to 23.11.3 (#1027) * fix: upgrade i18next from 23.10.1 to 23.11.3 Snyk has created this PR to upgrade i18next from 23.10.1 to 23.11.3. See this package in yarn: i18next See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade @types/react from 18.2.79 to 18.3.1 (#1028) * fix: upgrade @types/react from 18.2.79 to 18.3.1 Snyk has created this PR to upgrade @types/react from 18.2.79 to 18.3.1. See this package in yarn: @types/react See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade joi from 17.13.0 to 17.13.1 (#1029) * fix: upgrade joi from 17.13.0 to 17.13.1 Snyk has created this PR to upgrade joi from 17.13.0 to 17.13.1. See this package in yarn: joi See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * formatting * stashing changes * add missing return to the .map within ExploreProjects.js * modify .map return in ExploreProjects.js * added new blue65b to tailwind config * updated ExploreProjects component. Made it so entire section explore other projects section of html is generated inside component to increase reusability * updated benefits navigator page with new ExploreProjects component * documenting code * more documentation * TopNavBar Component (#1033) * add colour for header border * modify top header to match design * add translations for topnavbar * modify paragraph line height * remove default ul, ol, and li styling and apply to TextRender * add styling to list on homepage * create TopNavBar, add animations to menu.css * add TopNavBar to Layout.js * apply correct fonts to TopNavBar * replace margins in img/lang toggle with padding * add aria labels, create unit test * create story entry for TopNavBar * augment TopNavBar unit test * add featureflag for TopNavBar in Layout.js * fix svg attribute names, topnav active (#1034) * updates to Card component to increase responsiveness for other components * updates to ExploreProjects component, added dynamicH2 function which whandles changing the text content for mobile view, also updated styles to match designs * storybook entry for ExploreProjects component * Revert "updates to Card component to increase responsiveness for other components" fixed height syntax This reverts commit 355338d. * created media queries for dynamic H2 * stashing changes * removed unused media queries * removed unused code from exploreProjects component * added shuffle function, added filterProjects function, updated props for exploreProjects component * removed unused prop from storybook entry * removed active project from storybook entry as the logic for filteringhas been moved outside of the component * removed unused H2 * updated storybook entry * adding unit testing * clean up ExploreProjects CSS * updated unit test * created pages/api/shuffle.js for reusability on other pages, updated comments * moved shuffle.js to /lib/utils, updated imports, removed unused await statement * created filterProjects util * removed filterProjects and imported as a util * added explore other projects section to each project page * removed unused import * added missing height properties to experiementsData images * updated unit test for oas-benefits-estimator --------- Co-authored-by: Jordan Willis <[email protected]> Co-authored-by: Jordan <[email protected]> Co-authored-by: Shaun Laughland <[email protected]> Co-authored-by: snyk-bot <[email protected]>
* add colour for section background * update Card image container height * show 3 projects on homepage and add new section * create updates section component * fix dictionary entry used on project pages * modify Card.js to allow passing styling and html descriptions * allow excluding H1 nodes in FragmentRender * update homepage query * update homepage to use FragmentRender * add viewport to HEAD on all pages for tailwind * use grid ExploreUpdates.js * update homepage to use new query and fragments * add ExploreUpdates to home page and project pages * fix list styling on project pages * add margin for new sections on project pages * remove defaultprops throwing warnings * modify Card.js description to accept html * drill down for H1 in HeaderText.jsx * update mockdata * update home.test.js * revert dateModified * use js defaults in Link.js * create unit test and story for ExploreUpdates.js * add updates section to all article pages * rename filterProjects -> filterItems * sort updates by most recent on all pages * add missing ski link to homepage * add key to update pages to ensure proper navigation between update pages * update atoms/Link to support passing in next/link
…es (#1049) * fix dictionary offset * use new scLabProject property in ExploreUpdates * remove slice from filterItems.js * remove hardcoded updatesData, replace with persisted query * create All Updates page * create MultiSelectField component * Project page unit tests (#1040) * updated mockStore.js to include current projects * removed updatesData query from pages since the data is available through the pageData object, updated props value for updatesData * added unit testing for pages * updated mockStore.js to include current projects * updated mockStore.js * added experiments data import to OAS benefits navigator test * create i18n files for MultiSelect * [Snyk] Upgrade sharp from 0.33.3 to 0.33.4 (#1037) * fix: upgrade sharp from 0.33.3 to 0.33.4 Snyk has created this PR to upgrade sharp from 0.33.3 to 0.33.4. See this package in yarn: sharp See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade @apollo/client from 3.10.1 to 3.10.4 (#1041) * fix: upgrade @apollo/client from 3.10.1 to 3.10.4 Snyk has created this PR to upgrade @apollo/client from 3.10.1 to 3.10.4. See this package in yarn: @apollo/client See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * [Snyk] Upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2 (#1042) * fix: upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2 Snyk has created this PR to upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2. See this package in yarn: @fortawesome/react-fontawesome See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * [Snyk] Upgrade @types/react from 18.3.2 to 18.3.3 (#1043) * fix: upgrade @types/react from 18.3.2 to 18.3.3 Snyk has created this PR to upgrade @types/react from 18.3.2 to 18.3.3. See this package in yarn: @types/react See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * Image vertical line content update (#1047) * updated mockStore.js to include current projects * removed updatesData query from pages since the data is available through the pageData object, updated props value for updatesData * added unit testing for pages * updated mockStore.js to include current projects * updated mockStore.js * added experiments data import to OAS benefits navigator test * updated ImageVerticalLineContent component to include optional collapse, also updated unit test and storybook entry * updated TextWithImage component to include optional collapse in the case of image-vertical-line-content, also updated unit test and storybook entry * added CollapseData to mock store so it can be reused by each component that has a Collapse * updated FragmentRender.js to include TextRender component for fragments that have children prop, also removed unused generateCollapseElements() call, also updated unit test and storybook entry * updated ImageWithCollapse unit test to check that the collapse is opened after being clicked * Revert "updated ImageWithCollapse unit test to check that the collapse is opened after being clicked" This reverts commit 08f0333. * updated ImageWithCollapse unit test to check that the collapse is opened after being clicked, also updated storybook entry to include TextRender component * added data-testid to elements for testing * removed unused imports * added switch case to SCLabs-Comp-Content-Image-v1 that only sets title, longDesc and children props if the layout is image-vertical-line-content, without this the app was failing to build in prod * added storybook entry and unit test for TextWithImage w/Collapse * updated Collapse Data to more accurately represent data in testing * updated FragmentRender storybook entry and unit test * updated ImageVerticalLineContent component to match dashboard page design * updated ImageVerticalLineContent story and unit test * updated ImageWithCollapse story and unit test * updated TextWithImage story and unit test * commented out feature-section div so that we dont forget about it. uncomment and view in storybook to see that design matches dashboard page * [Snyk] Upgrade sharp from 0.33.3 to 0.33.4 (#1037) * fix: upgrade sharp from 0.33.3 to 0.33.4 Snyk has created this PR to upgrade sharp from 0.33.3 to 0.33.4. See this package in yarn: sharp See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade @apollo/client from 3.10.1 to 3.10.4 (#1041) * fix: upgrade @apollo/client from 3.10.1 to 3.10.4 Snyk has created this PR to upgrade @apollo/client from 3.10.1 to 3.10.4. See this package in yarn: @apollo/client See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * [Snyk] Upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2 (#1042) * fix: upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2 Snyk has created this PR to upgrade @fortawesome/react-fontawesome from 0.2.0 to 0.2.2. See this package in yarn: @fortawesome/react-fontawesome See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * [Snyk] Upgrade @types/react from 18.3.2 to 18.3.3 (#1043) * fix: upgrade @types/react from 18.3.2 to 18.3.3 Snyk has created this PR to upgrade @types/react from 18.3.2 to 18.3.3. See this package in yarn: @types/react See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> * add wrapper to ImageVerticalLineContent story --------- Co-authored-by: Kris Charbonneau <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> Co-authored-by: Jordan Willis <[email protected]> * update MultiSelect a11y translations * add react-select as dependency * increase h2l line-height value * update MultiSelect component * allow for custom styling of Card.js heading * create util function getDictionaryTerm * update ExploreUpdates section to use getDctionaryTerm * dictionary prop on home passed in as array * update updates.js * include scLabProject in project/article queries * remove superfuous check in ProjectInfo.test.js * allow excluding H1s in FragmentRender * ExploreUpdates story consumes dictionary directly * sort updates newest->oldest and remove unused imports * pages use getDictionaryTerm and pass in dictionary array directly * update yarn.lock * slice projects array in project page ExploreProjects * pass TextRender to FragmentRender SCLabs-Image-v1 * update Dashboard page and query to support FragmentRender * update unit tests * add new AEM_BASE_URL var (#1050) * linting --------- Co-authored-by: Marcus Blais <[email protected]> Co-authored-by: Kris Charbonneau <[email protected]> Co-authored-by: snyk-bot <[email protected]>
|
Storybooks Link For Branch |
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
|
Coverage Report Link for Branch |
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Update October 2024
This PR includes all design and content updates that are part of the May 2024 design update.
See the designs here: https://www.figma.com/design/ke3SrZNGMP3AjwzMMuEgbo/[current]-BDM-DECD-SC-Labs?node-id=19239-43264&t=g2S8D7ARF4lotf5Q-0
Test Instructions