DO NOT MERGE #1039
Closed
DO NOT MERGE #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unit testing for ArticleCTA component * Unit testing for BasicTextWithImage component * Unit testing for Button component * fixed typos in ImageWithCollapse.stories.js * Unit testing for ImageWithCollapse component * Unit testing for QuoteVerticalLineContent component * Unit testing for ImageVerticalLineContent component * Unit testing for TextContent component * Unit testing for TextWithImage component * updated alt arg value to match unit test query * fix dcterms metadata to better support AA (#1019) * Font Optimization (#1020) * setup google fonts to be served locally * implement fonts using next/font * apply Lato and Notosans variables directly to Modal * remove duplicate main landmark * fix duplicate main landmarks in error pages * added on click test-case for ImageWithCollapse.test * small update to ImageWithCollapse.test * stashing WIP changes for ImageWithCollapse.test.js * updated title path for fragment components * Created storybook entry for FragmentRender component * created unit test for FragmentRender component * add missing ISR_ENABLED ARG to Dockerfile (#1030) * add nullish coalescing operator to error page AA check (#1024) * upgrade nextjs version to fix issue with sharp and output:standalone (#1025) * [Snyk] Upgrade: react, react-dom (#1026) * fix: upgrade multiple dependencies with Snyk Snyk has created this PR to upgrade: - react from 18.2.0 to 18.3.1. See this package in yarn: - react-dom from 18.2.0 to 18.3.1. See this package in yarn: See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade i18next from 23.10.1 to 23.11.3 (#1027) * fix: upgrade i18next from 23.10.1 to 23.11.3 Snyk has created this PR to upgrade i18next from 23.10.1 to 23.11.3. See this package in yarn: i18next See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade @types/react from 18.2.79 to 18.3.1 (#1028) * fix: upgrade @types/react from 18.2.79 to 18.3.1 Snyk has created this PR to upgrade @types/react from 18.2.79 to 18.3.1. See this package in yarn: @types/react See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * [Snyk] Upgrade joi from 17.13.0 to 17.13.1 (#1029) * fix: upgrade joi from 17.13.0 to 17.13.1 Snyk has created this PR to upgrade joi from 17.13.0 to 17.13.1. See this package in yarn: joi See this project in Snyk: https://app.snyk.io/org/p0nder0sa/project/270b554d-5de8-452f-ad01-8bceb7604a92?utm_source=github&utm_medium=referral&page=upgrade-pr * update yarn.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Jordan <[email protected]> * formatting * stashing changes * add missing return to the .map within ExploreProjects.js * modify .map return in ExploreProjects.js * added new blue65b to tailwind config * updated ExploreProjects component. Made it so entire section explore other projects section of html is generated inside component to increase reusability * updated benefits navigator page with new ExploreProjects component * documenting code * more documentation * TopNavBar Component (#1033) * add colour for header border * modify top header to match design * add translations for topnavbar * modify paragraph line height * remove default ul, ol, and li styling and apply to TextRender * add styling to list on homepage * create TopNavBar, add animations to menu.css * add TopNavBar to Layout.js * apply correct fonts to TopNavBar * replace margins in img/lang toggle with padding * add aria labels, create unit test * create story entry for TopNavBar * augment TopNavBar unit test * add featureflag for TopNavBar in Layout.js * fix svg attribute names, topnav active (#1034) * updates to Card component to increase responsiveness for other components * updates to ExploreProjects component, added dynamicH2 function which whandles changing the text content for mobile view, also updated styles to match designs * storybook entry for ExploreProjects component * Revert "updates to Card component to increase responsiveness for other components" fixed height syntax This reverts commit 355338d. * created media queries for dynamic H2 * stashing changes * removed unused media queries * removed unused code from exploreProjects component * added shuffle function, added filterProjects function, updated props for exploreProjects component * removed unused prop from storybook entry * removed active project from storybook entry as the logic for filteringhas been moved outside of the component * removed unused H2 * updated storybook entry * adding unit testing * clean up ExploreProjects CSS * updated unit test * created pages/api/shuffle.js for reusability on other pages, updated comments * moved shuffle.js to /lib/utils, updated imports, removed unused await statement * created filterProjects util * removed filterProjects and imported as a util * added explore other projects section to each project page * removed unused import * added missing height properties to experiementsData images * updated unit test for oas-benefits-estimator --------- Co-authored-by: Jordan Willis <[email protected]> Co-authored-by: Jordan <[email protected]> Co-authored-by: Shaun Laughland <[email protected]> Co-authored-by: snyk-bot <[email protected]>
|
Storybooks Link For Branch |
|
Coverage Report Link for Branch |
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
1 similar comment
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Task name](Replace with a link to your task)
Description of the task you completed and/or features added. If it is a visual component or feature,
add a screenshot(s) of it.
Test Instructions
Definition of Done