Fix date filter behavior #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #91 Update the blank date filter to populate with earliest and latest incident dates by default and handle device language. * Modify `src/components/filters/DateFilter.tsx` to handle blank dates by populating them with the earliest and latest incident dates. * Change the "invalid date" message to be displayed in the device language. * Ensure the `FilterDate` component does not dispatch a filter immediately when it's added. * Modify `src/components/graphs/IncidentsStats.tsx` to export the logic to calculate the earliest and latest incident dates. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DSSD-Madison/Red-CORAL/issues/91?shareId=XXXX-XXXX-XXXX-XXXX).
|
Visit the preview URL for this PR (updated for commit ba95c4a): https://red-coral-map--pr94-tetratsunami-fix-dat-a0l2ggjt.web.app (expires Thu, 19 Dec 2024 16:33:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 448fecd22aac1efe5f83b62a6963333ee67c448b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Update the blank date filter to populate with earliest and latest incident dates by default and handle device language.
Modify
src/components/filters/DateFilter.tsxto handle blank dates by populating them with the earliest and latest incident dates.Change the "invalid date" message to be displayed in the device language.
Ensure the
FilterDatecomponent does not dispatch a filter immediately when it's added.Modify
src/components/graphs/IncidentsStats.tsxto export the logic to calculate the earliest and latest incident dates.For more details, open the Copilot Workspace session.