Omansh #2
Closed
Omansh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Omanshb Can you please include detailed screen recording showing that the completion of Part 2 in the beginner project is giving the valid result? |
karkir0003
requested changes
Oct 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
https://drive.google.com/file/d/1S4Qgzw9cP1T8yIaUem8Zo25yiuTdbZIp/view?usp=sharing Here is a screen recording of all my part2 changes |
|
@Omanshb looks good to me. I'll close this PR since we don't want to merge this work into the actual DLP app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains part 1 and part 2 of the beginner project for Omansh Bainsla.