Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge refresh-button to dev #587

Closed
wants to merge 9 commits into from
Closed

Merge refresh-button to dev #587

wants to merge 9 commits into from

Conversation

dwu359
Copy link
Contributor

@dwu359 dwu359 commented Feb 20, 2023

Added refresh button to refresh executions table, added download button to make files of completed executions downloadable

@karkir0003
Copy link
Member

@dwu359 github actions build check failed

@farisdurrani

@farisdurrani
Copy link
Member

farisdurrani commented Feb 20, 2023

Ignore the Prettier build action. That plugin is down for everyone rn. See creyD/prettier_action#110

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address me and faris' comments @dwu359

backend/aws_helpers/s3_utils/s3_client.py Outdated Show resolved Hide resolved
backend/driver.py Show resolved Hide resolved
backend/driver.py Outdated Show resolved Hide resolved
backend/driver.py Outdated Show resolved Hide resolved
@karkir0003
Copy link
Member

build checks still failing @dwu359

@karkir0003
Copy link
Member

@farisdurrani any comments on daniel's pr?

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address faris' comments and my followup questions

@karkir0003
Copy link
Member

@farisdurrani can u review this pr?

@farisdurrani
Copy link
Member

PR approved, feel free to merge this in @dwu359

@karkir0003 karkir0003 self-requested a review February 22, 2023 02:32
@farisdurrani
Copy link
Member

Due to serious git conflicts, we're making a new branch and PR for this: #592

@farisdurrani
Copy link
Member

Do not merge this PR in

@farisdurrani farisdurrani self-requested a review February 22, 2023 03:18
@farisdurrani farisdurrani mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants