Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diameter of Binary Tree added #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neha030
Copy link

@neha030 neha030 commented Jun 29, 2021

I have added the C++ code for Diameter of a Binary Tree
Please review my code.

@neha030
Copy link
Author

neha030 commented Jun 29, 2021

Fixes #47

@nimisha-yadav
Copy link
Member

Hey @neha030! As per the contribution guidelines, can you describe your algorithm in brief at the starting of your code? Also, your code uses O(n^2) complexity, can you optimize it?

@neha030
Copy link
Author

neha030 commented Jul 12, 2021

Hey @neha030! As per the contribution guidelines, can you describe your algorithm in brief at the starting of your code? Also, your code uses O(n^2) complexity, can you optimize it?

Ok I will add the Description of the algorithm and try to optimize it

Copy link
Collaborator

@v-vanisha v-vanisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @neha030, you need to include a minimum of 2 test cases for your code according to the guidelines. Kindly do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants