[FEAT] 4주차 테스트 코드 10개 작성 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikekks
commented
Mar 21, 2024
•
mikekks
commented
- 사알짝 급하게 짠 느낌이 없지 않아 있는데 다음주엔 퀄 좀 높여 보겠습니다..ㅎㅎ..
- Enum 쪽 로직을 잘못 짰네여..! 이 부분은 수정하겠습니다..!
sung-silver
approved these changes
Apr 1, 2024
| runtimeOnly 'com.h2database:h2' | ||
|
|
||
| } | ||
|
|
||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| finalizedBy jacocoTestCoverageVerification | ||
|
|
||
| jacoco { |
Comment on lines
+38
to
+44
| public static AgeEnum getAgeEnum(int age) { | ||
| return Arrays.stream(AgeEnum.values()) | ||
| .filter(ageEnum -> ageEnum.minAge <= age && ageEnum.maxAge >= age) | ||
| .findAny() | ||
| .orElseThrow(() -> new CustomException(INVALID_AGE_ENUM, INVALID_AGE_ENUM.getMessage())); | ||
| } | ||
|
|
There was a problem hiding this comment.
오 이렇게 수정하셨군요!! 근데 서비스의 이해를 높여드리자면 TEENAGER의 minAge는 0살이면 좋을 것 같습니다! 10대 이하일 경우 에러를 반환하는게 아니라 그냥 10대의 결과를 반환하는게 저희 솝커톤의 서비스 흐름이었거든요!
| doReturn(resultResponseDTO).when(resultService).saveResult(any()); | ||
|
|
||
| // when | ||
| final ResultActions resultActions = mockMvc.perform( |
There was a problem hiding this comment.
테스트에서도 변하지 않는 것에 대해 final을 붙이는 습관 좋은 것 같습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.