Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'create_problem' command work and add options #2256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make 'create_problem' command work and add options #2256

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ee1d99
Make 'create_problem' command work and add options
DapperX May 12, 2023
2534255
Apply suggestions from code review
DapperX May 12, 2023
2111528
Update judge/management/commands/create_problem.py
DapperX May 12, 2023
52342c7
Apply suggestions from code review
DapperX May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions judge/management/commands/create_problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.core.management.base import BaseCommand

from judge.models import Problem, ProblemGroup, ProblemType
from judge.models import Language, Problem, ProblemGroup, ProblemType


class Command(BaseCommand):
Expand All @@ -12,12 +12,28 @@ def add_arguments(self, parser):
parser.add_argument('body', help='problem description')
parser.add_argument('type', help='problem type')
parser.add_argument('group', help='problem group')
parser.add_argument('time_limit', help='time limit in (fractional) seconds')
parser.add_argument('memory_limit', help='memory limit in kilobytes')
parser.add_argument('points', help='problem points')
parser.add_argument('--partial-points', help='allow partial points',
action='store_true', default=False, dest='pr_pts')
parser.add_argument('--all-languages', help='allow all languages',
action='store_true', default=False, dest='all_lang')

def handle(self, *args, **options):
problem = Problem()
problem.code = options['code']
problem.name = options['name']
problem.description = options['body']
problem.group = ProblemGroup.objects.get(name=options['group'])
problem.types = [ProblemType.objects.get(name=options['type'])]
problem.time_limit = options['time_limit']
problem.memory_limit = options['memory_limit']
problem.points = options['points']
if options['pr_pts']:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this if necessary? It seems we can just do

problem.partial = options['pr_pts']

Copy link
Author

@DapperX DapperX May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this for not assuming the default value of this field, i.e., if Allows partial points is enabled by default at some points, the code should still work, though I don't have strong opinions about this.

problem.partial = 1
problem.save()

problem.types.set([ProblemType.objects.get(name=options['type'])])
if options['all_lang']:
problem.allowed_languages.set(Language.objects.all())
problem.save()