Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender 4.2.1 #1136

Merged
merged 31 commits into from
Sep 12, 2024
Merged

Blender 4.2.1 #1136

merged 31 commits into from
Sep 12, 2024

Conversation

Griperis
Copy link
Contributor

@Griperis Griperis commented Jul 30, 2024

Transitions blenderproc to latest Blender LTS - 4.2.1. This enables to use new Blender features and advantages to its development also in the blenderproc environment. This enables:

  • use new geometry nodes features
  • load asset .blend files that were transitioned to 4.2.0 already
  • take advantage of the improved cycles renderer (PrincipledBSDF, SoftFalloff)
  • not be bound to older Blender versions when creating scenes that are then loaded into blenderproc

@cornerfarmer

This comment has been minimized.

@DLR-RM DLR-RM deleted a comment from cla-bot bot Jul 30, 2024
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
@Griperis
Copy link
Contributor Author

Griperis commented Aug 2, 2024

Added 4 commits migrating blenderproc to 4.0.2. according to breaking changes I and documentation are aware of.

The python cli.py run tests/run_all.py passes for me ✅.

@cornerfarmer can you run the tests again? Also I am susceptible to making the changes backward compatible with 3.6 if you consider it viable. My use case for this is so its easily possible to change the major version that's installed with blenderproc and the code will not be the block.

The next step is Blender 4.1, which should be easier, as it doesn't have many breaking changes.

@cornerfarmer

This comment was marked as outdated.

New API in Blender 4.0, the first 'context' argument no longer exists.
…d .inputs

The latter was deprecated in favor of the prior.
This is no longer available from Blender 4.1
The 'import_mesh.ply' was replaced by '.wm.ply_import'.
@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

…ender 4.1

Since Blender 4.1 the .exr depth outputs are one channel
instead of three channels. The imageio.v3.imread
using 'opencv' can't open single channel .exr. Thus
using nodes we create three channel image output
from the depth again.

This might be fixed in future versions of Blender, fix
to respect the file foramt 'Color' property (that's actually set to RGB)
was already merged into master:

https://projects.blender.org/blender/blender/commit/40be124184bb571669b7346a36003c33c412cb20
@cornerfarmer

This comment was marked as outdated.

Since Blender 4.1 'AgX' is the new default, but to yield semi-similar results we want to keep the default as 'Filmic'.
Adjusted breaking API changes, and adding
of the smooth by angle modifier - which is now
actually less prone to error.
@cornerfarmer

This comment was marked as outdated.

@Griperis Griperis changed the title Blender 4.1.1 Blender 4.2.0 Aug 16, 2024
@Griperis Griperis marked this pull request as ready for review August 16, 2024 11:07
Using the 'bpy.ops.modifier_add_node_group' would be superior,
but it doesn't work correctly in background mode.
@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

So the 'bpy.context.collection' can be used afterwards. This worked
in Blender 4.1, but in 4.2 deleting the collection objects doesn't
make the root collection as the active in context.
@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer

This comment was marked as outdated.

@cornerfarmer
Copy link
Member

cornerfarmer commented Sep 9, 2024

BlenderProcHelper result for run 612:

Done with: [amass_human_poses_python 27s, auto_shading_python 9s, basic_python 13s, blenderkit_python 20s, bop_object_on_surface_sampling_python 96s, bop_object_physics_positioning_python 125s, bop_object_pose_sampling_python 118s, bop_scene_replication_python 184s, camera_depth_of_field_python 20s, camera_object_pose_python 22s, camera_random_trajectories_python 60s, camera_sampling_python 22s, coco_annotations_python 16s, diffuse_color_image_python 21s, dust_python 20s, entity_displacement_modifier_python 14s, entity_manipulation_python 10s, front_3d_object_sampling_python 95s, front_3d_python 99s, front_3d_with_improved_mat_python 116s, git_log 1s, haven_python 26s, ikea_python 18s, kinect_azure_noise_python 16s, lens_distortion_python 17s, lens_distortion_python 12s, light_sampling_python 14s, material_manipulation_python 11s, material_randomizer_python 12s, matterport3d_python 66s, motion_blur_rolling_shutter_python 29s, motion_blur_rolling_shutter_python 27s, multi_render_python 304s, nocs_python 19s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 28s, physics_convex_decomposition_python 144s, physics_positioning_python 25s, pix3d_python 17s, point_clouds_python 14s, random_backgrounds_python 19s, random_room_constructor_python 80s, replica_python 228s, scenenet_python 49s, scenenet_with_cctextures_python 62s, semantic_segmentation_python 13s, shapenet_python 21s, shapenet_with_scenenet_python 57s, shapenet_with_suncg_python 55s, spotlight_python 24s, stereo_matching_python 49s, stereo_matching_with_projector_python 147s, suncg_basic_python 35s, suncg_with_cam_sampling_python 58s, suncg_with_improved_mat_python 66s, suncg_with_object_replacer_python 59s, tests_python 28s, urdf_loading_and_manipulation_python 59s]
Done with 59 of 59 tests.
There were errors:
Unit tests output:

................
----------------------------------------------------------------------
Ran 16 tests in 23.825s

OK

urdf_loading_and_manipulation (main_python)

The output of urdf_loading_and_manipulation:main_python:000000_scene_gt_info_json has changed:

Expand
+ root['0'][2]['bbox_visib'][3]: 25
- root['0'][2]['bbox_visib'][3]: 23

stereo_matching (main_python)

The output of stereo_matching:main_python:disparity has changed: Diff: 0.0329, Pixel diff: 0.0031



Compare image Newly generated image

stereo_matching_with_projector (main_python)

The output of stereo_matching_with_projector:main_python:disparity has changed: Diff: 0.0105, Pixel diff: 0.0052



Compare image Newly generated image

Pylint output

Expand

Messages

Module blenderproc (blenderproc/__init__.py)

Line Col. Type Symbol ID Obj Message
12 44 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.camera.CameraProjection (blenderproc/python/camera/CameraProjection.py)

Line Col. Type Symbol ID Obj Message
4 0 warning unused-import W0611
Unused create_primitive imported from blenderproc.python.types.MeshObjectUtility
10 0 convention ungrouped-imports C0412
Imports from package blenderproc are not grouped
29 31 convention trailing-whitespace C0303
Trailing whitespace
35 0 convention trailing-whitespace C0303
Trailing whitespace
41 0 convention line-too-long C0301
Line too long (147/120)
85 8 refactor no-else-return R1705 depth_at_points_via_raytracing
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
89 0 convention trailing-whitespace C0303
Trailing whitespace
90 0 convention line-too-long C0301
Line too long (134/120)
141 0 convention trailing-whitespace C0303
Trailing whitespace
159 7 convention trailing-whitespace C0303
Trailing whitespace
161 33 convention trailing-whitespace C0303
Trailing whitespace
165 0 convention line-too-long C0301
Line too long (132/120)
167 0 convention trailing-newlines C0305
Trailing newlines

Module blenderproc.python.loader.BopLoader (blenderproc/python/loader/BopLoader.py)

Line Col. Type Symbol ID Obj Message
353 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.loader.CCMaterialLoader (blenderproc/python/loader/CCMaterialLoader.py)

Line Col. Type Symbol ID Obj Message
73 0 convention line-too-long C0301
Line too long (152/120)

Module blenderproc.python.postprocessing.PostProcessingUtility (blenderproc/python/postprocessing/PostProcessingUtility.py)

Line Col. Type Symbol ID Obj Message
15 0 convention line-too-long C0301
Line too long (137/120)

Module blenderproc.python.renderer.RendererUtility (blenderproc/python/renderer/RendererUtility.py)

Line Col. Type Symbol ID Obj Message
246 0 convention trailing-whitespace C0303
Trailing whitespace
314 0 convention trailing-whitespace C0303
Trailing whitespace
504 0 convention trailing-whitespace C0303
Trailing whitespace
682 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.types.EntityUtility (blenderproc/python/types/EntityUtility.py)

Line Col. Type Symbol ID Obj Message
170 11 convention unidiomatic-typecheck C0123 Entity.duplicate
Use isinstance() rather than type() for a typecheck.

Module blenderproc.python.types.LightUtility (blenderproc/python/types/LightUtility.py)

Line Col. Type Symbol ID Obj Message
125 12 refactor consider-using-augmented-assign R6104 Light.setup_as_projector
Use '/=' to do an augmented assign directly
216 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.types.MeshObjectUtility (blenderproc/python/types/MeshObjectUtility.py)

Line Col. Type Symbol ID Obj Message
517 87 convention trailing-whitespace C0303
Trailing whitespace
522 0 convention line-too-long C0301
Line too long (125/120)
525 0 convention trailing-whitespace C0303
Trailing whitespace
531 68 warning unused-variable W0612 MeshObject.add_auto_smooth_modifier
Unused variable 'data_from'
539 16 warning self-assigning-variable W0127 MeshObject.add_auto_smooth_modifier
Assigning the same variable 'modifier' to itself
541 0 convention trailing-whitespace C0303
Trailing whitespace
551 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
555 0 convention trailing-whitespace C0303
Trailing whitespace
557 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
558 0 convention trailing-whitespace C0303
Trailing whitespace
560 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
562 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
563 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
564 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
565 90 convention trailing-whitespace C0303
Trailing whitespace
565 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
566 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
567 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
568 0 convention trailing-whitespace C0303
Trailing whitespace
569 23 convention trailing-whitespace C0303
Trailing whitespace
570 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
572 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
573 20 convention trailing-whitespace C0303
Trailing whitespace
574 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
575 0 convention trailing-whitespace C0303
Trailing whitespace
576 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
608 0 convention line-too-long C0301
Line too long (130/120)
619 7 convention trailing-whitespace C0303
Trailing whitespace
627 8 warning unused-variable W0612 create_from_point_cloud
Unused variable 'p'
655 0 convention trailing-whitespace C0303
Trailing whitespace
730 28 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.Initializer (blenderproc/python/utility/Initializer.py)

Line Col. Type Symbol ID Obj Message
80 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.InstallUtility (blenderproc/python/utility/InstallUtility.py)

Line Col. Type Symbol ID Obj Message
129 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.writer.BopWriterUtility (blenderproc/python/writer/BopWriterUtility.py)

Line Col. Type Symbol ID Obj Message
9 0 convention wrong-import-order C0411
standard import "from typing import List, Optional, Dict, Tuple" should be placed before "import trimesh"
10 0 convention wrong-import-order C0411
standard import "import warnings" should be placed before "import trimesh"
11 0 convention wrong-import-order C0411
standard import "import datetime" should be placed before "import trimesh"
18 0 convention wrong-import-order C0411
standard import "import sys" should be placed before "import trimesh"
62 0 convention line-too-long C0301
Line too long (131/120)
79 8 warning redefined-outer-name W0621 write_bop
Redefining name 'dataset_objects' from outer scope (line 536)
172 44 warning protected-access W0212 write_bop
Access to a protected member _pyrender_init of a client class
172 15 refactor consider-using-with R1732 write_bop
Consider using 'with' for resource-allocating operations
176 0 convention trailing-whitespace C0303
Trailing whitespace
182 0 convention trailing-whitespace C0303
Trailing whitespace
305 21 warning redefined-outer-name W0621 _BopWriterUtility.get_frame_gt
Redefining name 'dataset_objects' from outer scope (line 536)
392 38 warning redefined-outer-name W0621 _BopWriterUtility.write_frames
Redefining name 'dataset_objects' from outer scope (line 536)
518 0 convention trailing-whitespace C0303
Trailing whitespace
530 78 convention trailing-whitespace C0303
Trailing whitespace
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'renderer' undefined at the module level
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'renderer_large' undefined at the module level
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'dataset_objects' undefined at the module level
552 0 convention line-too-long C0301
Line too long (173/120)
567 78 convention trailing-whitespace C0303
Trailing whitespace
573 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_masks_iteration
Using global for 'renderer' but no assignment is done
573 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_masks_iteration
Using global for 'dataset_objects' but no assignment is done
580 0 convention trailing-whitespace C0303
Trailing whitespace
670 0 convention line-too-long C0301
Line too long (160/120)
671 0 convention trailing-whitespace C0303
Trailing whitespace
672 0 convention trailing-whitespace C0303
Trailing whitespace
675 0 convention line-too-long C0301
Line too long (196/120)
688 11 convention trailing-whitespace C0303
Trailing whitespace
690 78 convention trailing-whitespace C0303
Trailing whitespace
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'renderer_large' but no assignment is done
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'dataset_objects' but no assignment is done
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'renderer' but no assignment is done
700 11 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
701 12 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
702 12 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
709 0 convention trailing-whitespace C0303
Trailing whitespace
837 0 convention line-too-long C0301
Line too long (202/120)
838 0 convention trailing-whitespace C0303
Trailing whitespace
846 44 warning redefined-outer-name W0621 _BopWriterUtility.calc_gt_coco
Redefining name 'dataset_objects' from outer scope (line 536)

Module blenderproc.python.writer.GifWriterUtility (blenderproc/python/writer/GifWriterUtility.py)

Line Col. Type Symbol ID Obj Message
13 0 convention wrong-import-position C0413
Import "from blenderproc.scripts.visHdf5Files import vis_data" should be placed at the top of the module
14 0 convention wrong-import-position C0413
Import "from blenderproc.python.utility.Utility import Utility" should be placed at the top of the module

Module blenderproc.scripts.quickstart (blenderproc/scripts/quickstart.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
11 -1 warning pointless-string-statement W0105
String statement has no effect
13 0 convention wrong-import-position C0413
Import "import numpy as np" should be placed at the top of the module

Metrics

Count per types

Name Count
convention 63
refactor 3
warning 34

Count per messages

Name Count
trailing-whitespace 40
line-too-long 12
trailing-newlines 1
no-else-return 1
ungrouped-imports 1
unused-import 1
consider-using-augmented-assign 1
unidiomatic-typecheck 1
bad-indentation 13
self-assigning-variable 1
unused-variable 2
redefined-outer-name 4
protected-access 4
consider-using-with 1
global-variable-undefined 3
global-variable-not-assigned 5
wrong-import-order 4
wrong-import-position 3
missing-module-docstring 1
pointless-string-statement 1

Count per modules

Name Count
blenderproc 1
blenderproc.python.camera.CameraProjection 13
blenderproc.python.loader.CCMaterialLoader 1
blenderproc.python.loader.BopLoader 1
blenderproc.python.postprocessing.PostProcessingUtility 1
blenderproc.python.renderer.RendererUtility 4
blenderproc.python.types.LightUtility 2
blenderproc.python.types.EntityUtility 1
blenderproc.python.types.MeshObjectUtility 31
blenderproc.python.utility.Initializer 1
blenderproc.python.utility.InstallUtility 1
blenderproc.python.writer.BopWriterUtility 38
blenderproc.python.writer.GifWriterUtility 2
blenderproc.scripts.quickstart 3

Count per path

Name Count
blenderproc/__init__.py 1
blenderproc/python/camera/CameraProjection.py 13
blenderproc/python/loader/CCMaterialLoader.py 1
blenderproc/python/loader/BopLoader.py 1
blenderproc/python/postprocessing/PostProcessingUtility.py 1
blenderproc/python/renderer/RendererUtility.py 4
blenderproc/python/types/LightUtility.py 2
blenderproc/python/types/EntityUtility.py 1
blenderproc/python/types/MeshObjectUtility.py 31
blenderproc/python/utility/Initializer.py 1
blenderproc/python/utility/InstallUtility.py 1
blenderproc/python/writer/BopWriterUtility.py 38
blenderproc/python/writer/GifWriterUtility.py 2
blenderproc/scripts/quickstart.py 3
***The tests are done.*** Check the log:

Last update: 09/09/2024, 14:04:49

Copy link
Member

@cornerfarmer cornerfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

blenderproc/python/types/MeshObjectUtility.py Show resolved Hide resolved
blenderproc/python/types/MeshObjectUtility.py Outdated Show resolved Hide resolved
blenderproc/python/renderer/RendererUtility.py Outdated Show resolved Hide resolved
@Griperis Griperis changed the title Blender 4.2.0 Blender 4.2.1 Sep 10, 2024
@cornerfarmer
Copy link
Member

cornerfarmer commented Sep 12, 2024

BlenderProcHelper result for run 614:

Done with: [amass_human_poses_python 27s, auto_shading_python 9s, basic_python 14s, blenderkit_python 20s, bop_object_on_surface_sampling_python 99s, bop_object_physics_positioning_python 132s, bop_object_pose_sampling_python 111s, bop_scene_replication_python 182s, camera_depth_of_field_python 20s, camera_object_pose_python 22s, camera_random_trajectories_python 60s, camera_sampling_python 22s, coco_annotations_python 14s, diffuse_color_image_python 22s, dust_python 22s, entity_displacement_modifier_python 12s, entity_manipulation_python 10s, front_3d_object_sampling_python 93s, front_3d_python 104s, front_3d_with_improved_mat_python 115s, git_log 1s, haven_python 28s, ikea_python 18s, kinect_azure_noise_python 14s, lens_distortion_python 16s, lens_distortion_python 12s, light_sampling_python 13s, material_manipulation_python 10s, material_randomizer_python 10s, matterport3d_python 67s, motion_blur_rolling_shutter_python 26s, motion_blur_rolling_shutter_python 27s, multi_render_python 288s, nocs_python 20s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 25s, physics_convex_decomposition_python 142s, physics_positioning_python 24s, pix3d_python 17s, point_clouds_python 16s, random_backgrounds_python 20s, random_room_constructor_python 82s, replica_python 224s, scenenet_python 48s, scenenet_with_cctextures_python 63s, semantic_segmentation_python 16s, shapenet_python 20s, shapenet_with_scenenet_python 56s, shapenet_with_suncg_python 56s, spotlight_python 22s, stereo_matching_python 49s, stereo_matching_with_projector_python 146s, suncg_basic_python 35s, suncg_with_cam_sampling_python 58s, suncg_with_improved_mat_python 68s, suncg_with_object_replacer_python 60s, tests_python 35s, urdf_loading_and_manipulation_python 61s]
Done with 59 of 59 tests.
There were errors:
Unit tests output:

................
----------------------------------------------------------------------
Ran 16 tests in 30.324s

OK

urdf_loading_and_manipulation (main_python)

The output of urdf_loading_and_manipulation:main_python:000000_scene_gt_info_json has changed:

Expand
+ root['0'][2]['bbox_visib'][3]: 25
- root['0'][2]['bbox_visib'][3]: 23

stereo_matching (main_python)

The output of stereo_matching:main_python:disparity has changed: Diff: 0.0398, Pixel diff: 0.0036



Compare image Newly generated image

Pylint output

Expand

Messages

Module blenderproc (blenderproc/__init__.py)

Line Col. Type Symbol ID Obj Message
12 44 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.camera.CameraProjection (blenderproc/python/camera/CameraProjection.py)

Line Col. Type Symbol ID Obj Message
4 0 warning unused-import W0611
Unused create_primitive imported from blenderproc.python.types.MeshObjectUtility
10 0 convention ungrouped-imports C0412
Imports from package blenderproc are not grouped
29 31 convention trailing-whitespace C0303
Trailing whitespace
35 0 convention trailing-whitespace C0303
Trailing whitespace
41 0 convention line-too-long C0301
Line too long (147/120)
85 8 refactor no-else-return R1705 depth_at_points_via_raytracing
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
89 0 convention trailing-whitespace C0303
Trailing whitespace
90 0 convention line-too-long C0301
Line too long (134/120)
141 0 convention trailing-whitespace C0303
Trailing whitespace
159 7 convention trailing-whitespace C0303
Trailing whitespace
161 33 convention trailing-whitespace C0303
Trailing whitespace
165 0 convention line-too-long C0301
Line too long (132/120)
167 0 convention trailing-newlines C0305
Trailing newlines

Module blenderproc.python.loader.BopLoader (blenderproc/python/loader/BopLoader.py)

Line Col. Type Symbol ID Obj Message
353 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.loader.CCMaterialLoader (blenderproc/python/loader/CCMaterialLoader.py)

Line Col. Type Symbol ID Obj Message
73 0 convention line-too-long C0301
Line too long (152/120)

Module blenderproc.python.postprocessing.PostProcessingUtility (blenderproc/python/postprocessing/PostProcessingUtility.py)

Line Col. Type Symbol ID Obj Message
15 0 convention line-too-long C0301
Line too long (137/120)

Module blenderproc.python.renderer.RendererUtility (blenderproc/python/renderer/RendererUtility.py)

Line Col. Type Symbol ID Obj Message
246 0 convention trailing-whitespace C0303
Trailing whitespace
314 0 convention trailing-whitespace C0303
Trailing whitespace
504 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.types.EntityUtility (blenderproc/python/types/EntityUtility.py)

Line Col. Type Symbol ID Obj Message
170 11 convention unidiomatic-typecheck C0123 Entity.duplicate
Use isinstance() rather than type() for a typecheck.

Module blenderproc.python.types.LightUtility (blenderproc/python/types/LightUtility.py)

Line Col. Type Symbol ID Obj Message
125 12 refactor consider-using-augmented-assign R6104 Light.setup_as_projector
Use '/=' to do an augmented assign directly
216 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.types.MeshObjectUtility (blenderproc/python/types/MeshObjectUtility.py)

Line Col. Type Symbol ID Obj Message
520 87 convention trailing-whitespace C0303
Trailing whitespace
526 0 convention line-too-long C0301
Line too long (122/120)
529 0 convention trailing-whitespace C0303
Trailing whitespace
535 68 warning unused-variable W0612 MeshObject.add_auto_smooth_modifier
Unused variable 'data_from'
543 16 warning self-assigning-variable W0127 MeshObject.add_auto_smooth_modifier
Assigning the same variable 'modifier' to itself
545 0 convention trailing-whitespace C0303
Trailing whitespace
555 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
559 0 convention trailing-whitespace C0303
Trailing whitespace
561 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
562 0 convention trailing-whitespace C0303
Trailing whitespace
564 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
566 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
567 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
568 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
569 90 convention trailing-whitespace C0303
Trailing whitespace
569 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
570 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
571 0 warning bad-indentation W0311
Bad indentation. Found 13 spaces, expected 12
572 0 convention trailing-whitespace C0303
Trailing whitespace
573 23 convention trailing-whitespace C0303
Trailing whitespace
574 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
576 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
577 20 convention trailing-whitespace C0303
Trailing whitespace
578 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
579 0 convention trailing-whitespace C0303
Trailing whitespace
580 0 warning bad-indentation W0311
Bad indentation. Found 9 spaces, expected 8
612 0 convention line-too-long C0301
Line too long (130/120)
623 7 convention trailing-whitespace C0303
Trailing whitespace
631 8 warning unused-variable W0612 create_from_point_cloud
Unused variable 'p'
659 0 convention trailing-whitespace C0303
Trailing whitespace
734 28 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.Initializer (blenderproc/python/utility/Initializer.py)

Line Col. Type Symbol ID Obj Message
80 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.InstallUtility (blenderproc/python/utility/InstallUtility.py)

Line Col. Type Symbol ID Obj Message
129 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.writer.BopWriterUtility (blenderproc/python/writer/BopWriterUtility.py)

Line Col. Type Symbol ID Obj Message
9 0 convention wrong-import-order C0411
standard import "from typing import List, Optional, Dict, Tuple" should be placed before "import trimesh"
10 0 convention wrong-import-order C0411
standard import "import warnings" should be placed before "import trimesh"
11 0 convention wrong-import-order C0411
standard import "import datetime" should be placed before "import trimesh"
18 0 convention wrong-import-order C0411
standard import "import sys" should be placed before "import trimesh"
62 0 convention line-too-long C0301
Line too long (131/120)
79 8 warning redefined-outer-name W0621 write_bop
Redefining name 'dataset_objects' from outer scope (line 536)
172 44 warning protected-access W0212 write_bop
Access to a protected member _pyrender_init of a client class
172 15 refactor consider-using-with R1732 write_bop
Consider using 'with' for resource-allocating operations
176 0 convention trailing-whitespace C0303
Trailing whitespace
182 0 convention trailing-whitespace C0303
Trailing whitespace
305 21 warning redefined-outer-name W0621 _BopWriterUtility.get_frame_gt
Redefining name 'dataset_objects' from outer scope (line 536)
392 38 warning redefined-outer-name W0621 _BopWriterUtility.write_frames
Redefining name 'dataset_objects' from outer scope (line 536)
518 0 convention trailing-whitespace C0303
Trailing whitespace
530 78 convention trailing-whitespace C0303
Trailing whitespace
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'renderer' undefined at the module level
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'renderer_large' undefined at the module level
534 8 warning global-variable-undefined W0601 _BopWriterUtility._pyrender_init
Global variable 'dataset_objects' undefined at the module level
552 0 convention line-too-long C0301
Line too long (173/120)
567 78 convention trailing-whitespace C0303
Trailing whitespace
573 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_masks_iteration
Using global for 'renderer' but no assignment is done
573 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_masks_iteration
Using global for 'dataset_objects' but no assignment is done
580 0 convention trailing-whitespace C0303
Trailing whitespace
670 0 convention line-too-long C0301
Line too long (160/120)
671 0 convention trailing-whitespace C0303
Trailing whitespace
672 0 convention trailing-whitespace C0303
Trailing whitespace
675 0 convention line-too-long C0301
Line too long (196/120)
688 11 convention trailing-whitespace C0303
Trailing whitespace
690 78 convention trailing-whitespace C0303
Trailing whitespace
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'renderer_large' but no assignment is done
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'dataset_objects' but no assignment is done
696 8 warning global-variable-not-assigned W0602 _BopWriterUtility._calc_gt_info_iteration
Using global for 'renderer' but no assignment is done
700 11 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
701 12 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
702 12 warning protected-access W0212 _BopWriterUtility._calc_gt_info_iteration
Access to a protected member _renderer of a client class
709 0 convention trailing-whitespace C0303
Trailing whitespace
837 0 convention line-too-long C0301
Line too long (202/120)
838 0 convention trailing-whitespace C0303
Trailing whitespace
846 44 warning redefined-outer-name W0621 _BopWriterUtility.calc_gt_coco
Redefining name 'dataset_objects' from outer scope (line 536)

Module blenderproc.python.writer.GifWriterUtility (blenderproc/python/writer/GifWriterUtility.py)

Line Col. Type Symbol ID Obj Message
13 0 convention wrong-import-position C0413
Import "from blenderproc.scripts.visHdf5Files import vis_data" should be placed at the top of the module
14 0 convention wrong-import-position C0413
Import "from blenderproc.python.utility.Utility import Utility" should be placed at the top of the module

Module blenderproc.scripts.quickstart (blenderproc/scripts/quickstart.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
11 -1 warning pointless-string-statement W0105
String statement has no effect
13 0 convention wrong-import-position C0413
Import "import numpy as np" should be placed at the top of the module

Metrics

Count per types

Name Count
convention 62
refactor 3
warning 34

Count per messages

Name Count
trailing-whitespace 39
line-too-long 12
trailing-newlines 1
no-else-return 1
ungrouped-imports 1
unused-import 1
consider-using-augmented-assign 1
unidiomatic-typecheck 1
bad-indentation 13
self-assigning-variable 1
unused-variable 2
redefined-outer-name 4
protected-access 4
consider-using-with 1
global-variable-undefined 3
global-variable-not-assigned 5
wrong-import-order 4
wrong-import-position 3
missing-module-docstring 1
pointless-string-statement 1

Count per modules

Name Count
blenderproc 1
blenderproc.python.camera.CameraProjection 13
blenderproc.python.loader.CCMaterialLoader 1
blenderproc.python.loader.BopLoader 1
blenderproc.python.postprocessing.PostProcessingUtility 1
blenderproc.python.renderer.RendererUtility 3
blenderproc.python.types.LightUtility 2
blenderproc.python.types.EntityUtility 1
blenderproc.python.types.MeshObjectUtility 31
blenderproc.python.utility.InstallUtility 1
blenderproc.python.utility.Initializer 1
blenderproc.python.writer.BopWriterUtility 38
blenderproc.python.writer.GifWriterUtility 2
blenderproc.scripts.quickstart 3

Count per path

Name Count
blenderproc/__init__.py 1
blenderproc/python/camera/CameraProjection.py 13
blenderproc/python/loader/CCMaterialLoader.py 1
blenderproc/python/loader/BopLoader.py 1
blenderproc/python/postprocessing/PostProcessingUtility.py 1
blenderproc/python/renderer/RendererUtility.py 3
blenderproc/python/types/LightUtility.py 2
blenderproc/python/types/EntityUtility.py 1
blenderproc/python/types/MeshObjectUtility.py 31
blenderproc/python/utility/InstallUtility.py 1
blenderproc/python/utility/Initializer.py 1
blenderproc/python/writer/BopWriterUtility.py 38
blenderproc/python/writer/GifWriterUtility.py 2
blenderproc/scripts/quickstart.py 3
***The tests are done.*** Check the log:

Last update: 09/12/2024, 11:40:33

Copy link
Member

@cornerfarmer cornerfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@cornerfarmer cornerfarmer merged commit ee197a9 into DLR-RM:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants