Feature element boundary [3/3] #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-element_boundary
lukasdreyer
reviewed
Jun 10, 2024
|
Ready for review - i added a test case. |
|
Is now ready for re-review. |
lukasdreyer
reviewed
Sep 13, 2024
src/t8_forest/t8_forest.cxx
Outdated
Comment on lines
2115
to
2139
| else { | ||
| SC_ABORT ("This forest has holes and a computation of boundary elements is not supported. Once " | ||
| "https://github.com/DLR-AMR/t8code/issues/825 is resolved, the function will be available.\n"); | ||
| } | ||
| /* we need to compute the face neighbors to know whether the element is a boundary element. */ | ||
| const int is_balanced = t8_forest_is_balanced (forest); | ||
| int num_neighbors; | ||
| t8_element_t **neighbor_leaves; | ||
| t8_locidx_t *pelement_indices; | ||
| t8_eclass_scheme_c *pneigh_scheme; | ||
| /* The forest has holes, the leaf could lie inside a tree but its neighbor was deleted. */ | ||
| t8_forest_leaf_face_neighbors (forest, local_tree, leaf, &neighbor_leaves, face, NULL, &num_neighbors, | ||
| &pelement_indices, &pneigh_scheme, is_balanced); | ||
|
|
||
| if (num_neighbors == 0) { | ||
| /* The element has no neighbors, it is a boundary element. */ | ||
| return 1; | ||
| } | ||
| else { | ||
| /* If neighbors were found, these arrays were allocated and need clean-up. */ | ||
| T8_FREE (neighbor_leaves); | ||
| T8_FREE (pelement_indices); | ||
| /* This leaf is not a boundary leaf. */ | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
I think it's cleaner, if the additional computations for forests with holes is moved into the else branch, or the SC_ABORT is moved outside the else branch, so it becomes clear that for incomplete trees we can return earlier
There was a problem hiding this comment.
I removed the else and added a descriptive comment.
I hope this clarifies the issue.
| scheme = t8_scheme_new_default_cxx (); | ||
| forest = t8_forest_new_uniform (cmesh, scheme, level, 0, sc_MPI_COMM_WORLD); | ||
| t8_forest_ref (forest); | ||
| //const int maxlevel = t8_forest_get_maxlevel (forest); |
|
Found the bug, tests should pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Implemented a function to check whether a leaf element is at the domain boundary or not.
We need to take special care with forests with holes, since these forests have inner boundaries.
Currently draft since we need to implement a test case.
Merge after #1079 and #1080
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.Licence
doc/(or already has one)