Updates from package template #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
commented
Dec 6, 2024
Cadair
force-pushed
the
cruft-manual-update
branch
from
5cb0ca4 to
223bd96
Compare
CodSpeed Performance ReportMerging #472 will not alter performanceComparing Summary
|
SolarDrew
reviewed
Dec 6, 2024
This concerns me a bit though... |
yeah I have no idea why 🤔 |
From a cursory glance at the dashboard it looks like a dask regression. |
Then I suggest we pin dask so it doesn't make all our stuff really slow? |
Cadair
force-pushed
the
cruft-manual-update
branch
from
df70cc9 to
8295818
Compare
|
Turns out it's an astropy regression caused by astropy/astropy#15474 |
Cadair
added
the
No Changelog Entry Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been generated by a script, it should update the repo with the latest changes from the package template.