Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performace of TiledDataset repr #467

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Nov 14, 2024

No description provided.

@Cadair Cadair requested a review from SolarDrew November 14, 2024 16:59
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #467 will not alter performance

Comparing Cadair:speed_up_repr_tiled (b58416f) with main (66035ba)

Summary

✅ 11 untouched benchmarks

@SolarDrew
Copy link
Contributor

I think this wants to be rebased to include charges from #468 .

@Cadair Cadair requested a review from SolarDrew January 6, 2025 10:32
@Cadair
Copy link
Member Author

Cadair commented Jan 6, 2025

The changelog fail is expected as the bot only reads the config from main

@Cadair Cadair added pre-commit.ci autofix Run the pre-commit bot on this PR automatically and removed pre-commit.ci autofix Run the pre-commit bot on this PR automatically labels Jan 6, 2025
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix Run the pre-commit bot on this PR automatically label Jan 6, 2025
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Cadair Cadair merged commit 9c17054 into DKISTDC:main Jan 6, 2025
23 of 25 checks passed
@Cadair Cadair deleted the speed_up_repr_tiled branch January 6, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants