Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin on pytest-benchmark #459

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove pin on pytest-benchmark #459

merged 1 commit into from
Dec 18, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Oct 29, 2024

No description provided.

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #459 will degrade performances by 18.16%

Comparing pytest_benchmarks_5 (45ec9b0) with main (18b7e0b)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main pytest_benchmarks_5 Change
test_dataset_compute_data_full_files 1.9 s 2.3 s -16.03%
test_dataset_compute_data_partial_files 1.6 s 2 s -18.16%
test_generate_celestial 5.9 ms 5.3 ms +11.24%

@Cadair Cadair force-pushed the pytest_benchmarks_5 branch from 427f5e6 to 45ec9b0 Compare December 18, 2024 15:04
@Cadair Cadair added the No Changelog Entry Needed This pull request does not need a changelog entry label Dec 18, 2024
@Cadair Cadair marked this pull request as ready for review December 18, 2024 15:49
@Cadair
Copy link
Member Author

Cadair commented Dec 18, 2024

It seems that the issue has been fixed.

@Cadair Cadair merged commit d5789c4 into main Dec 18, 2024
23 of 25 checks passed
@Cadair Cadair deleted the pytest_benchmarks_5 branch December 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant