Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usages of copy_arrays with memmap for asdf>=3.1.0 #422

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

zacharyburnett
Copy link
Contributor

follow-on to asdf-format/asdf#1797

Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #422 will not alter performance

Comparing zacharyburnett:deprecate/copy_arrays (d6e859f) with main (567a2fd)

Summary

✅ 9 untouched benchmarks

@zacharyburnett zacharyburnett force-pushed the deprecate/copy_arrays branch 5 times, most recently from 7ba5282 to 28f2060 Compare July 18, 2024 19:41
@zacharyburnett zacharyburnett changed the title replace usages of copy_arrays with memmap replace usages of copy_arrays with memmap for asdf>=3.1.0 Jul 18, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 19:53
@braingram
Copy link
Contributor

braingram commented Aug 6, 2024

pre-commit.ci autofix

The bot gave me a 👎 for this. Not sure what that means.

@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Aug 6, 2024

pre-commit.ci autofix

The bot gave me a 👎 for this. Not sure what that means.

maybe it doesn't like you? what a rude bot

@Cadair
Copy link
Member

Cadair commented Aug 7, 2024

pre-commit.ci autofix

dkist/dataset/loader.py Outdated Show resolved Hide resolved
@Cadair Cadair force-pushed the deprecate/copy_arrays branch from 049e22e to d6e859f Compare August 26, 2024 09:50
@Cadair Cadair merged commit bf3dc0a into DKISTDC:main Aug 26, 2024
20 checks passed
@zacharyburnett zacharyburnett deleted the deprecate/copy_arrays branch August 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants