WIP Start adding some basic benchmarking infrastructure #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Apr 18, 2024
tox.ini
Outdated
| [testenv:benchmarks] | ||
| description = Run benchmarks against latest release to ensure there are no performance regressions | ||
| commands = | ||
| {env:PYTEST_COMMAND} -k test_benchmarks --benchmark-autosave --benchmark-compare=0001 |
There was a problem hiding this comment.
I propose that instead of -k test_benchmarks we put the @pytest.mark.benchmark marker on all our benchmarks and then do -m benchmark to select tests with that marker.
Cadair
reviewed
Apr 18, 2024
dkist/tests/test_benchmarks.py
Outdated
Comment on lines
9
to
12
| vispdir = tmp_path_factory.mktemp("data") | ||
| with gzip.open(Path(rootdir) / "large_visp.asdf.gz", mode="rb") as gfo: | ||
| with open(vispdir / "test_visp.asdf", mode="wb") as afo: | ||
| afo.write(gfo.read()) |
There was a problem hiding this comment.
presumeably we would want this bit to be in a fixture so it's not part of the code getting benchmarked?
No idea if this will work
Which is annoying since it was exactly not the point
|
Going to close this as it's been made obsolete by #382 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rudimentary so far but hopefully will be useful in tracking performance and preventing regressions.