Use execTime for Fido search #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, merge when ready 👍 |
SolarDrew
approved these changes
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 97.38% 97.73% +0.35%
==========================================
Files 34 34
Lines 1987 1987
==========================================
+ Hits 1935 1942 +7
+ Misses 52 45 -7 ☔ View full report in Codecov by Sentry. |
SolarDrew
added a commit
to SolarDrew/dkist
that referenced
this pull request
Feb 26, 2024
This reverts commit 62039c2.
Cadair
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Add online test for Time search parameter * Bit of tidying * Add another constraint to make sure we get the right dataset * Parametrize the test because that's how we do things * Revert "Use execTime for fido search (#326)" This reverts commit 62039c2. * Use startTime for fido search again, but right this time * Put the parameters the right way round so it actually works * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.