Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the large PR:
This PR adds creation strategies for creating interdependent objects that can be used for creating display sets and archive items. Strategies should return an item that can be used to finalize the strategy, the CIV strategies return a
ComponentInterfaceValuePostRequest
.Only tests for the prep stage of the strategies have been added since testing the actual execution of the strategies is non-trivial and is heavily reliant on the involved integration tests. The strategies are a result of heavy testing and extraction from the helper functions on the original PR.
This PR implements the logic behind the following:
Allowing both
str
, andlist[str]
Sourcing a CIV from one file no longer requires a one-lengthed list, the helper functions automagically handle both. This also applies to pathlib.Path.
RE-use of images / CIVs
Can provide a CIV or Image to the strategies and it will be re-used.