Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] the confirmDeletion parameter (missing feature) #45

Merged
merged 5 commits into from
Dec 4, 2024
Merged

[update] the confirmDeletion parameter (missing feature) #45

merged 5 commits into from
Dec 4, 2024

Conversation

serhiipylypchuk1991
Copy link
Contributor

No description provided.

@serhiipylypchuk1991 serhiipylypchuk1991 self-assigned this Nov 28, 2024
kullias
kullias reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@kullias kullias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same setting was added to:

  • column shape (boolean)
  • row shape (boolean)
  • links shape (boolean, inside config)
  • comments shape (boolean, inside config)

It has sense to add them as well

@serhiipylypchuk1991 serhiipylypchuk1991 changed the title [update] add the cardShape.confirmDeletion parameter (missing feature) [update] the confirmDeletion parameter (missing feature) Dec 1, 2024
kullias
kullias requested changes Dec 2, 2024
View reviewed changes
docs/api/config/js_kanban_columnshape_config.md Outdated Show resolved Hide resolved
docs/api/config/js_kanban_columnshape_config.md Outdated Show resolved Hide resolved
docs/api/config/js_kanban_editorshape_config.md Outdated Show resolved Hide resolved
docs/api/config/js_kanban_rowshape_config.md Outdated Show resolved Hide resolved
@kullias kullias self-requested a review December 4, 2024 09:47
@serhiipylypchuk1991 serhiipylypchuk1991 merged commit 8e0050a into master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kullias kullias kullias approved these changes

Assignees

@serhiipylypchuk1991 serhiipylypchuk1991

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiipylypchuk1991 @kullias