Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate YaeLib #2385

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

integrate YaeLib #2385

wants to merge 7 commits into from

Conversation

qhy040404
Copy link
Member

Description

Related Issue

Checklist

  • The target PR branch is develop branch

@qhy040404 qhy040404 requested review from Copilot and Lightczx January 17, 2025 13:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 28 changed files in this pull request and generated 2 comments.

Files not reviewed (15)
  • src/Snap.Hutao/Snap.Hutao/Resource/Localization/SH.resx: Language not supported
  • src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Page/AchievementPage.xaml: Language not supported
  • src/Snap.Hutao/Snap.Hutao/Service/GachaLog/QueryProvider/GachaLogQueryWebCacheProvider.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Game/Account/IGameAccountService.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Game/Account/GameAccountService.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Game/IGameService.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/AvatarInfo/Factory/Builder/WeaponViewBuilderExtension.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Inventory/IInventoryService.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Extension/DictionaryExtension.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Extension/EnumerableExtension.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Yae/PlayerStore/StoreData.proto: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Inventory/InventoryService.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Model/InterChange/Achievement/UIAFInfo.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Core/LifeCycle/InterProcess/Yae/YaeDataType.cs: Evaluated as low risk
  • src/Snap.Hutao/Snap.Hutao/Service/Yae/YaeService.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Snap.Hutao/Snap.Hutao/Service/Yae/Achievement/AchievementParser.cs:68

  • The logic for determining timestampId, statusId, id, and currentId is complex and should be covered by tests to ensure its correctness.
if (data.Count > 20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant