Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move down local points assigment on gui/design #956

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

MagistrumT-T
Copy link
Contributor

fixes DFHack/dfhack#4202 by moving the assignment of points to after the center dragging logic which was manipulating self.marks

fixes DFHack/dfhack#4202 by moving the assignment of `points` to after the center dragging logic which was manipulating self.marks
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Copying from other reveiw] looks good! There looks to be an errant tab character that ci.pre-commit won't let pass. Please also add an entry in changelog.txt

Also remove some tabs that snuck in last time.
@myk002 myk002 merged commit 1bdb276 into DFHack:master Jan 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Center dragging shapes in gui/design lag behind by a tile.
2 participants