[confirm] refactor registry and reinstate remaining confirmation prompts #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
myk002
commented
Jan 4, 2024
myk002
commented
- reinstate trade screen prompts (I simplified the "confirm trade" logic since the things it previously warned against weren't actually dangerous)
- reinstate prompt for delete uniform
- reinstate prompt for convict criminal
- add frame debugging features when placing detection frames
- recover from screen resizes that push detection frames out of skew
I simplified the trade-confirm-trade logic since many of the options warned about damaging merchant mood, but none of the cases actually did (e.g. attempting to trade without items selected on both sides)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.