update confirm to use overlays and Lua-based confirmation prompts #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Jan 2, 2024
| end | ||
| end | ||
|
|
||
| if not next(registry) then |
There was a problem hiding this comment.
I think we should try to avoid checks like this because it makes development harder. Making any changes to the ConfirmConf invocations below would require manually clearing registry or restarting DF. Previously I think reloading the plugin (or the plugin lua module) was enough to apply changes.
There was a problem hiding this comment.
would it be better to take out the line that checks for duplicate IDs in ConfirmConf:init()? That was intended to catch copy paste errors, but if it were taken out, then the conf definitions would get automatically refreshed on every run
There was a problem hiding this comment.
suggested change in 1bf7996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DFHack/dfhack#4107
Fixes DFHack/dfhack#3282
Fixes DFHack/dfhack#3106
Fixes DFHack/dfhack#2814