Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated markdown script to work with Steam version #898

Closed
wants to merge 10 commits into from
Closed

Updated markdown script to work with Steam version #898

wants to merge 10 commits into from

Conversation

glotov4
Copy link
Contributor

@glotov4 glotov4 commented Nov 19, 2023

  • Added support of screens: - Unit/Health/Description - Unit/Personality/Traits - Item/Description
  • Added name, age & profession of units to description
  • Name of the default file now is “markdown_/worldName/_export.md”
  • Improved markdown formatting
  • Removed code for unsupported screens
  • Refactored the code

- Added support of screens:
    - Unit/Health/Description
    - Unit/Personality/Traits
    - Item/Description
- Added name, age & profession of units to description
- Refactored the code
- By default, file name is now “markdown_/worldName/_export.md”
- Improved markdown formatting
- Removed code for unsupported screens
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to do a more thorough review when I'm not on my phone, but this looks like an excellent start! Great job!

markdown.lua Outdated Show resolved Hide resolved
markdown.lua Outdated Show resolved Hide resolved
markdown.lua Outdated Show resolved Hide resolved
markdown.lua Outdated Show resolved Hide resolved
@glotov4
Copy link
Contributor Author

glotov4 commented Nov 20, 2023

I've acted on all comments and rewritten almost everything. Thank you!

However, this PR was opened from my markdown-fix branch. I'm creating a new pull request from my master to DFHack's master - #899
It didn't have an initial pull request merged until now, sorry.

@glotov4 glotov4 closed this Nov 20, 2023
@glotov4 glotov4 deleted the markdown-fix branch November 20, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants