-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated markdown script to work with Steam version #898
Conversation
glotov4
commented
Nov 19, 2023
- Added support of screens: - Unit/Health/Description - Unit/Personality/Traits - Item/Description
- Added name, age & profession of units to description
- Name of the default file now is “markdown_/worldName/_export.md”
- Improved markdown formatting
- Removed code for unsupported screens
- Refactored the code
- Added support of screens: - Unit/Health/Description - Unit/Personality/Traits - Item/Description - Added name, age & profession of units to description - Refactored the code - By default, file name is now “markdown_/worldName/_export.md” - Improved markdown formatting - Removed code for unsupported screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to do a more thorough review when I'm not on my phone, but this looks like an excellent start! Great job!
- Improved docs
argument with "-o" argument for overwrite operation
- Replacing whitespaces from user input with underscores - Removed redundant check "if unit or item"
- Option "-o" now can be passed before or after filename - Formatted the docs
I've acted on all comments and rewritten almost everything. Thank you! However, this PR was opened from my markdown-fix branch. I'm creating a new pull request from my master to DFHack's master - #899 |