unforbid: ignore tattered items by default #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds option to disable ignoring tattered items.
myk002
reviewed
Nov 10, 2023
unforbid.lua
Outdated
| @@ -22,6 +22,11 @@ local function unforbid_all(include_unreachable, quiet) | |||
| if not quiet then print((' unreachable: %s (skipping)'):format(item)) end | |||
| goto skipitem | |||
| end | |||
|
|
|||
| if ((not options.include_tattered) and item.wear >= 3) then | |||
There was a problem hiding this comment.
The threshold is debatable. Should it be configurable? I can see the player wanting it to match whatever cleanowned is set to. What should be the default? We should probably match the default cleanowned command in the control panel.
There was a problem hiding this comment.
fair point, the original request was to ignore X and XX, which is worn, not tattered, as that is where dwarves start being upset about it
|
Need to make sure that i fix the function signature so its backwards compatible as well, that change shouldn't be there either, in case something calls externally and expects the old signature. |
reorganize main function parameters for backwards compat
myk002
reviewed
Nov 11, 2023
myk002
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds option to disable ignoring tattered items.
this is very much a first pass with minimal testing :)
Fixes DFHack/dfhack#3967