Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspendmanager: walkable() now correctly identifies all walkable squares and broke out a new function to explicitly exclude cases where that tile is a tree branch #841

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

master-spike
Copy link
Contributor

@master-spike master-spike commented Sep 26, 2023

Fixes DFHack/dfhack#3814

This change fixes this issue. Decision of where to apply walkable() and where to apply isSuitableAccess() was discussed in the discord

@myk002 myk002 requested a review from plule September 26, 2023 08:18
Copy link
Contributor

@plule plule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it could use a changelog entry

@myk002 myk002 merged commit 76f5a2b into DFHack:master Sep 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

suspendmanager does not consider floor bars as walkable
3 participants