list-agreements overhaul #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ handling of Deity names (as mentioned in DFHack#390) + age of petitions + added status 'expired' for outstanding petitions more than 1 year old + race specific guild professions + formatting characters to reduce mid-wo rd wrapping - consolidated functions for output and name lookup - minimised repeated work within if...elseif... blocks
|
Example output:
|
myk002
requested changes
May 30, 2022
+run arguments handler for `all` and `help` +localised variables +culling resolved agreements by default +general good practices implemented
myk002
requested changes
May 31, 2022
Co-authored-by: Myk <[email protected]>
Hevlikn
commented
May 31, 2022
myk002
approved these changes
Jun 3, 2022
Hevlikn
commented
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling of Deity names (as mentioned in Adding Guild Names to output of list-agreements #390)
age of petitions
added status 'expired' for outstanding petitions more than 1 year old
race specific guild professions
formatting characters to reduce mid-wo
rd wrapping
consolidated functions for output and name lookup
minimised repeated work within if...elseif... blocks