Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert age argument to number in rejuvenate.lua #1340

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Eldresh
Copy link
Contributor

@Eldresh Eldresh commented Nov 27, 2024

due to the less than comparison, age must be converted to a number or else any attempt to use that argument causes the script to fail with "attempt to compare string with number".

due to the less than comparison, age must be converted to a number or else any attempt to use that argument causes the script to fail with "attempt to compare string with number".
@Eldresh Eldresh closed this Nov 27, 2024
@Eldresh Eldresh deleted the Eldresh-Rejuvenate-patch-1 branch November 27, 2024 03:48
@Eldresh Eldresh restored the Eldresh-Rejuvenate-patch-1 branch November 27, 2024 03:49
@Eldresh Eldresh deleted the Eldresh-Rejuvenate-patch-1 branch November 27, 2024 03:49
@Eldresh
Copy link
Contributor Author

Eldresh commented Nov 27, 2024

Trying to figure out why this deleted, sorry. New to doing PRs.

Edit: reopened, sorry. Didn't expect renaming to mess with this.

@Eldresh Eldresh restored the Eldresh-Rejuvenate-patch-1 branch November 27, 2024 03:50
@Eldresh Eldresh reopened this Nov 27, 2024
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you also add a line to the Fixes section of changelog.txt?

@Eldresh
Copy link
Contributor Author

Eldresh commented Nov 27, 2024

Looks good! Could you also add a line to the Fixes section of changelog.txt?

I can do that. Thanks for your patience, this is my first PR and I'm still figuring stuff out.

@myk002 myk002 merged commit d602db3 into DFHack:master Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants